Merge pull request #71027 from Expensify/revert-69090-fix-brief-appearance-of-no-expense-empty-view

[CP Staging] Revert "Fix - "This report has no expenses" briefly shown in Reports after clearing cache"

(cherry picked from commit 78d8869)

(cherry-picked to staging by roryabraham)

Author: cristipaval

src/libs/MoneyRequestReportUtils.ts

@@ -108,13 +108,13 @@ function shouldDisplayReportTableView(report: OnyxEntry<Report>, transactions: T
 function shouldWaitForTransactions(report: OnyxEntry<Report>, transactions: Transaction[] | undefined, reportMetadata: OnyxEntry<ReportMetadata>) {
     const isTransactionDataReady = transactions !== undefined;
     const isTransactionThreadView = isReportTransactionThread(report);
-    const isStillLoadingData = transactions?.length === 0 && (!!reportMetadata?.isLoadingInitialReportActions || report?.total !== 0);
-
+    const isStillLoadingData = !!reportMetadata?.isLoadingInitialReportActions || !!reportMetadata?.isLoadingOlderReportActions || !!reportMetadata?.isLoadingNewerReportActions;
     return (
         (isMoneyRequestReport(report) || isInvoiceReport(report)) &&
-        (!isTransactionDataReady || isStillLoadingData) &&
+        (!isTransactionDataReady || (isStillLoadingData && transactions?.length === 0)) &&
         !isTransactionThreadView &&
-        report?.pendingFields?.createReport !== CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD
+        report?.pendingFields?.createReport !== CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD &&
+        !reportMetadata?.hasOnceLoadedReportActions
     );
 }