Describe the bug
Behavior of var.enable_gluesync is broken.
- In ECS, setting
enable_gluesync to false will still trigger HMS docker image to use glue sync, but the IAM policy is not created, so it fails.
- In K8S, the env var
ENABLE_GLUESYNC is never passed to the HMS docker image, so enabling glue sync doesn't work.
Additional context
- The ECS issue is because when TF vars were change to
boolean instead of strings, the value for false gets passed to ENABLE_GLUESYNC as false. But the startup.sh code in the docker image does a if [ !-z $ENABLE_GLUESYNC ] check, which sees the value false as non-empty, so enables glue sync. For the correct way of fixing this, see how enable_metrics is being set in https://github.com/ExpediaGroup/apiary-data-lake/blob/master/templates.tf#L24.
- The K8S issue looks like an oversight of passing the correct value to
ENABLE_GLUESYNC.
Describe the bug
Behavior of
var.enable_gluesyncis broken.enable_gluesynctofalsewill still trigger HMS docker image to use glue sync, but the IAM policy is not created, so it fails.ENABLE_GLUESYNCis never passed to the HMS docker image, so enabling glue sync doesn't work.Additional context
booleaninstead of strings, the value forfalsegets passed toENABLE_GLUESYNCasfalse. But thestartup.shcode in the docker image does aif [ !-z $ENABLE_GLUESYNC ]check, which sees the valuefalseas non-empty, so enables glue sync. For the correct way of fixing this, see howenable_metricsis being set in https://github.com/ExpediaGroup/apiary-data-lake/blob/master/templates.tf#L24.ENABLE_GLUESYNC.