From 58568263a6b33765bf99714377365d667a80ad26 Mon Sep 17 00:00:00 2001 From: Patrick Arlt Date: Mon, 24 Nov 2025 14:59:42 -0800 Subject: [PATCH 1/2] fix(arcgis-rest-request): cleanup release workflows --- .github/workflows/pull-request-tests.yml | 59 ------------------------ .github/workflows/release.yml | 9 ++-- 2 files changed, 6 insertions(+), 62 deletions(-) delete mode 100644 .github/workflows/pull-request-tests.yml diff --git a/.github/workflows/pull-request-tests.yml b/.github/workflows/pull-request-tests.yml deleted file mode 100644 index 58e1a7a82..000000000 --- a/.github/workflows/pull-request-tests.yml +++ /dev/null @@ -1,59 +0,0 @@ -name: PR Tests - -# Only run on non-draft PRs, and when PRs are synched -on: - pull_request: - types: [opened, reopened, ready_for_review, synchronize] - # If the PR has other files, a push w/ just .md or /docs - # files will still cause tests to run - paths-ignore: - - "**.md" - - "docs/**" -jobs: - build: - if: github.event.pull_request.draft == false - runs-on: ${{ matrix.os }} - - strategy: - fail-fast: false - matrix: - os: [ubuntu-latest] - node: [20, 22] - - steps: - - uses: actions/checkout@v4 - - uses: actions/setup-node@v4 - with: - node-version: ${{ matrix.node }} - - - name: Install Dependencies - run: npm ci --legacy-peer-deps - - - name: Install Playwright Browsers - run: npx playwright install --with-deps - - - name: Build - run: npm run build - - - name: Lint - run: npm run lint - - - name: Test in CI - run: npm run test:ci - - - name: Code Coverage Summary Report - uses: irongut/CodeCoverageSummary@v1.3.0 - with: - filename: coverage/**/cobertura-coverage.xml - badge: true - fail_below_min: true - format: markdown - output: both - thresholds: "100 100" - - - name: Add Coverage PR Comment - uses: marocchino/sticky-pull-request-comment@v2 - if: github.event_name == 'pull_request' && matrix.node == 22 - with: - recreate: true - path: code-coverage-results.md diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 163862308..261a530d7 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -22,12 +22,12 @@ jobs: build_and_test: name: Build and Test - runs-on: ${{ matrix.os }} - strategy: matrix: os: [ubuntu-latest] - node: [24] + node: [20, 22, 24] + + runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v4 @@ -38,6 +38,9 @@ jobs: - name: Install run: npm ci --legacy-peer-deps + - name: Install Playwright Browsers + run: npx playwright install --with-deps + - name: Build run: npm run build From 6a6d2f85f39d9cc7d79544f9b74c04cb701acb8c Mon Sep 17 00:00:00 2001 From: Patrick Arlt Date: Mon, 24 Nov 2025 15:06:21 -0800 Subject: [PATCH 2/2] chore: revert --- .github/workflows/pre-release-tests.yml | 42 ----------------- .github/workflows/pull-request-tests.yml | 59 ++++++++++++++++++++++++ 2 files changed, 59 insertions(+), 42 deletions(-) delete mode 100644 .github/workflows/pre-release-tests.yml create mode 100644 .github/workflows/pull-request-tests.yml diff --git a/.github/workflows/pre-release-tests.yml b/.github/workflows/pre-release-tests.yml deleted file mode 100644 index 83cc2e8a0..000000000 --- a/.github/workflows/pre-release-tests.yml +++ /dev/null @@ -1,42 +0,0 @@ -name: Pre-Release Tests - -# On pushes to master (i.e. merging a PR) -# run all tests, on win, macos, linux, on node 12 & 14 -on: - push: - branches: - - main - # Don't run if it's just markdown or doc files - paths-ignore: - - "**.md" - - "docs/**" -jobs: - build: - runs-on: ${{ matrix.os }} - - strategy: - fail-fast: false - matrix: - os: [ubuntu-latest, macos-latest, windows-latest] - node: [20, 22] - - steps: - - uses: actions/checkout@v4 - - uses: actions/setup-node@v4 - with: - node-version: ${{ matrix.node }} - - - name: Install Dependencies - run: npm ci --legacy-peer-deps - - - name: Install Playwright Browsers - run: npx playwright install --with-deps - - - name: Build - run: npm run build - - - name: Lint - run: npm run lint - - - name: Test in CI - run: npm run test:ci diff --git a/.github/workflows/pull-request-tests.yml b/.github/workflows/pull-request-tests.yml new file mode 100644 index 000000000..58e1a7a82 --- /dev/null +++ b/.github/workflows/pull-request-tests.yml @@ -0,0 +1,59 @@ +name: PR Tests + +# Only run on non-draft PRs, and when PRs are synched +on: + pull_request: + types: [opened, reopened, ready_for_review, synchronize] + # If the PR has other files, a push w/ just .md or /docs + # files will still cause tests to run + paths-ignore: + - "**.md" + - "docs/**" +jobs: + build: + if: github.event.pull_request.draft == false + runs-on: ${{ matrix.os }} + + strategy: + fail-fast: false + matrix: + os: [ubuntu-latest] + node: [20, 22] + + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node }} + + - name: Install Dependencies + run: npm ci --legacy-peer-deps + + - name: Install Playwright Browsers + run: npx playwright install --with-deps + + - name: Build + run: npm run build + + - name: Lint + run: npm run lint + + - name: Test in CI + run: npm run test:ci + + - name: Code Coverage Summary Report + uses: irongut/CodeCoverageSummary@v1.3.0 + with: + filename: coverage/**/cobertura-coverage.xml + badge: true + fail_below_min: true + format: markdown + output: both + thresholds: "100 100" + + - name: Add Coverage PR Comment + uses: marocchino/sticky-pull-request-comment@v2 + if: github.event_name == 'pull_request' && matrix.node == 22 + with: + recreate: true + path: code-coverage-results.md