-
Notifications
You must be signed in to change notification settings - Fork 128
Add trusted publishing configuration #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modernizes the release process by implementing NPM's trusted publishing mechanism, eliminating the need for long-lived personal access tokens in favor of GitHub's OIDC-based authentication. This change enhances security by removing stored credentials and aligns with NPM's strengthened authentication requirements.
Key changes:
- Configured trusted publishing with OIDC for NPM package releases
- Replaced custom tokens with GitHub's built-in
GITHUB_TOKENfor Git operations - Updated Node.js version from 18 to 24 for the release workflow
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Updated to use trusted publishing with OIDC, added necessary permissions, upgraded Node.js to v24, and switched from custom tokens to GITHUB_TOKEN |
| .github/workflows/manual-release.yml | Removed manual release workflow (no longer needed with trusted publishing setup) |
| RELEASE.md | Updated documentation to reflect trusted publishing configuration and removed references to deprecated token management |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gavinr-maps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! one question:
Minimum allowed line rate is |
dixonyant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left only one comment.
| matrix: | ||
| os: [ubuntu-latest] | ||
| node: [18] | ||
| node: [24] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will we need to retroactively go through the other yml files and update them do remove legacy-peer-deps and update the node versions to 24 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dixonyant yes eventually we want to only be on LTS versions of Node in these tests but I wanted to make sure we were up to date here since have to use NPM 11.5.1
|
@dixonyant @gavinr-maps going to merge this and see if we get a release of the request package! |
This PR sets up trusted publishing for
@esri/arcgis-rest-*packages. Long lived personal tokens are on the way out after continued supply chain attacks.This PR switches to use NPM Trusted Publishing according to this documentation:
Then we switch to using the GitHub actions provided
GITHUB_TOKENinstead of the token in the repo secrets for the Git operations that make up the rest of the publishing process according to these docs:This PR will also need to updated to remove the
--legacy-peer-depsflags if #1272 merges first.