From 21db35068307a4ef1fa2238fb52314c963494dbf Mon Sep 17 00:00:00 2001 From: jakimowb Date: Wed, 18 Mar 2026 16:08:37 +0100 Subject: [PATCH 1/2] QgsRasterLayerSpectralProperties.badBands returns 1 (do use) as default --- qps/qgsrasterlayerproperties.py | 2 +- qps/speclib/gui/spectralprocessingdialog.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qps/qgsrasterlayerproperties.py b/qps/qgsrasterlayerproperties.py index 86d46d91..48b5a1b1 100644 --- a/qps/qgsrasterlayerproperties.py +++ b/qps/qgsrasterlayerproperties.py @@ -392,7 +392,7 @@ def wavelengthUnits(self) -> List[str]: """ return self.bandValues(None, SpectralPropertyKeys.WavelengthUnit) - def badBands(self, default: Optional[int] = None) -> List[int]: + def badBands(self, default: Optional[int] = 1) -> List[int]: """ Convenience function to return bad band (multiplier) values as list 0 = False = do not use diff --git a/qps/speclib/gui/spectralprocessingdialog.py b/qps/speclib/gui/spectralprocessingdialog.py index a5dcffa5..b7003825 100644 --- a/qps/speclib/gui/spectralprocessingdialog.py +++ b/qps/speclib/gui/spectralprocessingdialog.py @@ -901,13 +901,13 @@ def runAlgorithm(self, fail_fast: bool = False) -> None: spectralProperties = QgsRasterLayerSpectralProperties.fromRasterLayer(lyr) wl = spectralProperties.wavelengths() wlu = spectralProperties.wavelengthUnits() - bbl = spectralProperties.badBands() + bbl = spectralProperties.badBands(default=1) - # wavelength need to be defined for all bands + # wavelength needs to be defined for all bands if any([w is None for w in wl]): wl = None - # choose 1st wavelength unit for entire profile + # choose the 1st wavelength unit for the entire profile for w in wlu: if w not in [None, '']: wlu = w From f44a2d7a5da536564e9e89722bb02cfa4ab7d7cd Mon Sep 17 00:00:00 2001 From: jakimowb Date: Wed, 18 Mar 2026 16:37:28 +0100 Subject: [PATCH 2/2] reverted previous changed. --- qps/qgsrasterlayerproperties.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qps/qgsrasterlayerproperties.py b/qps/qgsrasterlayerproperties.py index 48b5a1b1..86d46d91 100644 --- a/qps/qgsrasterlayerproperties.py +++ b/qps/qgsrasterlayerproperties.py @@ -392,7 +392,7 @@ def wavelengthUnits(self) -> List[str]: """ return self.bandValues(None, SpectralPropertyKeys.WavelengthUnit) - def badBands(self, default: Optional[int] = 1) -> List[int]: + def badBands(self, default: Optional[int] = None) -> List[int]: """ Convenience function to return bad band (multiplier) values as list 0 = False = do not use