Skip to content

Commit a400bc4

Browse files
authored
Merge pull request #208 from Geesu/fix/self-all
Match method definition within Resource
2 parents f966fc8 + 192206b commit a400bc4

File tree

7 files changed

+7
-7
lines changed

7 files changed

+7
-7
lines changed

lib/easypost/customs_info.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# CustomsInfo objects contain CustomsItem objects and all necessary information for the generation of customs forms required for international shipping.
44
class EasyPost::CustomsInfo < EasyPost::Resource
55
# Retrieve a list of CustomsInfo objects
6-
def self.all
6+
def self.all(_filters = {}, _api_key = nil)
77
raise NotImplementedError.new('CustomsInfo.all not implemented.')
88
end
99
end

lib/easypost/customs_item.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# A CustomsItem object describes goods for international shipment and should be created then included in a CustomsInfo object.
44
class EasyPost::CustomsItem < EasyPost::Resource
55
# Retrieve a list of CustomsItem objects
6-
def self.all
6+
def self.all(_filters = {}, _api_key = nil)
77
raise NotImplementedError.new('CustomsItem.all not implemented.')
88
end
99
end

lib/easypost/order.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def buy(params = {})
2626
end
2727

2828
# Retrieve a list of Order objects.
29-
def self.all
29+
def self.all(_filters = {}, _api_key = nil)
3030
raise NotImplementedError.new('Order.all not implemented.')
3131
end
3232

lib/easypost/parcel.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Parcel objects represent the physical container being shipped.
44
class EasyPost::Parcel < EasyPost::Resource
55
# Retrieving all Parcel objects is not supported.
6-
def self.all
6+
def self.all(_filters = {}, _api_key = nil)
77
raise NotImplementedError.new('Parcel.all not implemented.')
88
end
99
end

lib/easypost/payment_method.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
class EasyPost::PaymentMethod < EasyPost::Resource
55
# <b>DEPRECATED:</b> Please use <tt>Billing class</tt> instead.
66
# Deprecated: v4.5.0 - v6.0.0
7-
def self.all(api_key = nil)
7+
def self.all(_filters = {}, api_key = nil)
88
warn '[DEPRECATION] `all` is deprecated. Please use `Billing.retrieve_payment_methods` instead.'
99
EasyPost::Billing.retrieve_payment_methods(api_key)
1010
end

lib/easypost/pickup.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def cancel(params = {})
2626
end
2727

2828
# Retrieve a list of all Pickup objects.
29-
def self.all
29+
def self.all(_filters = {}, _api_key = nil)
3030
raise NotImplementedError.new('Pickup.all not implemented.')
3131
end
3232

lib/easypost/rate.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# A Rate object contains all the details about the rate of a Shipment.
44
class EasyPost::Rate < EasyPost::Resource
55
# Retrieving all Rate objects is not supported.
6-
def self.all
6+
def self.all(_filters = {}, _api_key = nil)
77
raise NotImplementedError.new('Rate.all not implemented.')
88
end
99
end

0 commit comments

Comments
 (0)