Skip to content

Conversation

@Qfl3x
Copy link

@Qfl3x Qfl3x commented Nov 26, 2025

closes #177

@Qfl3x Qfl3x changed the title Trainstate implementation (WIP) Trainstate implementation Nov 27, 2025
@Qfl3x
Copy link
Author

Qfl3x commented Nov 27, 2025

I did some sanity checks and it looks good. for 100 runs the results match the previous implentation, and there are no odd gradient stuff.

I realized that the state return of RbQ10 was a bug, which is why there was a coercion statement in the train loop (the st = (;st = l[2].st) line). Once the RbQ10 state return was fixed it is no longer needed.

Perhaps the other state returns must be fixed as well?

@lazarusA
Copy link
Member

thanks a lot! now we need to integrate this properly, so that most of the previous workflow keeps working, and at the same time we can have access to this method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

switch to TrainState and/or single_train_step!

2 participants