-
Notifications
You must be signed in to change notification settings - Fork 115
Open
Description
We have a few pull requests that have been sitting on the queue for quite a while, and I would like to incorporate as many as I can. I don't want to merge my own pull requests before someone else reviews it, so if anyone has time to go through one or some of them, I would really appreciate it! This is the list of pending pull requests, they are all quite specific and straightforward.
- Replace built-in linear system solver with LAPACK #410 Use LAPACK for solving two-stream. I see that @mdietze already approved it, but @xiangtaoxu you mentioned you would like to check this one too. Let me know if you are fine with me merging it.
- ED2IN clean up #411 This is a long overdue PR that removes all parameters from ED2IN (so XML is the only place where they can be set) and I think @mdietze you would be the best person to review it.
- Migrate time stamp control from namelist to the meteorological driver header #413 This removes IMETAVG and adds an equivalent variable in the meteorological driver header. The rationale is explained in the pull request, but this is to reduce risks of incorrectly setting the averaging window.
- Minor code changes to allow CI tests to run #414 This has a few updates to the CI settings. This combined with Migrate time stamp control from namelist to the meteorological driver header #413 should fix the CI failures we have been experiencing.
Once these are all merged, I can check #282 #310 and #402, which will likely need de-conflicting, because they have been in the queue for a very long time. Additional reviewers would be great for these too.
Metadata
Metadata
Assignees
Labels
No labels