Skip to content

Commit 847db0b

Browse files
DYN-9269: Fix CBN output port name for range vs sequence (#16446)
1 parent 8ee04c9 commit 847db0b

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

src/DynamoCore/Graph/Nodes/CodeBlockUtils.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,9 @@ internal static string InferStaticTypeFromNode(AssociativeNode node)
304304
case ExprListNode:
305305
case ArrayNode:
306306
return "list";
307-
case RangeExprNode:
307+
case RangeExprNode ren:
308+
if (ren.HasRangeAmountOperator)
309+
return "sequence";
308310
return "range";
309311
case IdentifierNode idNode:
310312
return idNode.Value;

test/DynamoCoreTests/CodeBlockNodeTests.cs

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1544,6 +1544,24 @@ public void TestTooltipAndLabelMaxLength()
15441544
}
15451545
}
15461546

1547+
[Test]
1548+
[Category("UnitTests")]
1549+
public void TestOutportNameForRangeAndSequence()
1550+
{
1551+
var code =
1552+
@"0..10..#5;
1553+
0..10..1;
1554+
0..#4..1;
1555+
0..4..~2;";
1556+
var cbn = CreateCodeBlockNode();
1557+
UpdateCodeBlockNodeContent(cbn, code);
1558+
1559+
Assert.AreEqual("range", cbn.OutPorts[0].Name);
1560+
Assert.AreEqual("range", cbn.OutPorts[1].Name);
1561+
Assert.AreEqual("sequence", cbn.OutPorts[2].Name);
1562+
Assert.AreEqual("range", cbn.OutPorts[3].Name);
1563+
}
1564+
15471565
#region CodeBlockUtils Specific Tests
15481566
[Test]
15491567
[Category("UnitTests")]

0 commit comments

Comments
 (0)