Error in Running github action with commit id

[DorisAmoakohene]

@tdhock I am trying to run the github action for the issues I got working but I am getting an error, without the commit ids The action for the 4 test run perfectly but when I include the commit error I get an error

test.list <- list(
+   PerformRegression5424 = list(
+     pkg.edit.fun=quote(function(old.Package, new.Package, sha, new.pkg.path){
+       
+       pkg_find_replace <- function(glob, FIND, REPLACE){
+         atime::glob_find_replace(file.path(new.pkg.path, glob), FIND, REPLACE)
+       }
+       Package_regex <- gsub(".", "_?", old.Package, fixed=TRUE)
+       Package_ <- gsub(".", "_", old.Package, fixed=TRUE)
+       new.Package_ <- paste0(Package_, "_", sha)
+       
+       pkg_find_replace(
+         "DESCRIPTION",
+         paste0("Package:\\s+", old.Package),
+         paste("Package:", new.Package))
+       pkg_find_replace(
+         file.path("src","Makevars.*in"),
+         Package_regex,
+         new.Package_)
+       pkg_find_replace(
+         file.path("R", "onLoad.R"),
+         Package_regex,
+         new.Package_)
+       pkg_find_replace(
+         file.path("R", "onLoad.R"),
+         sprintf('packageVersion\\("%s"\\)', old.Package),
+         sprintf('packageVersion\\("%s"\\)', new.Package))
+       pkg_find_replace(
+         file.path("src", "init.c"),
+         paste0("R_init_", Package_regex),
+         paste0("R_init_", gsub("[.]", "_", new.Package_)))
+       pkg_find_replace(
+         "NAMESPACE",
+         sprintf('useDynLib\\("?%s"?', Package_regex),
+         paste0('useDynLib(', new.Package_))
+     }),
+     commit.id = quote(list("Before"="be2f72e6f5c90622fe72e1c315ca05769a9dc854",
+                      "Regression"="e793f53466d99f86e70fc2611b708ae8c601a451", 
+                      "Fixed"="58409197426ced4714af842650b0cc3b9e2cb842")),
+     N = quote(10^seq(3, 8)),
+     expr = quote(data.table:::`[.data.table`(dt_mod, , N := .N, by = g)),
+     setup = quote({
+       n <- N/100
+       set.seed(1L)
+       dt <- data.table(
+         g = sample(seq_len(n), N, TRUE),
+         x = runif(N),
+         key = "g")
+       dt_mod <- copy(dt)
+     })
+   ),
+   Significantrolling = list(
+     pkg.edit.fun=quote(function(old.Package, new.Package, sha, new.pkg.path){
+       
+       pkg_find_replace <- function(glob, FIND, REPLACE){
+         atime::glob_find_replace(file.path(new.pkg.path, glob), FIND, REPLACE)
+       }
+       Package_regex <- gsub(".", "_?", old.Package, fixed=TRUE)
+       Package_ <- gsub(".", "_", old.Package, fixed=TRUE)
+       new.Package_ <- paste0(Package_, "_", sha)
+       
+       pkg_find_replace(
+         "DESCRIPTION",
+         paste0("Package:\\s+", old.Package),
+         paste("Package:", new.Package))
+       pkg_find_replace(
+         file.path("src","Makevars.*in"),
+         Package_regex,
+         new.Package_)
+       pkg_find_replace(
+         file.path("R", "onLoad.R"),
+         Package_regex,
+         new.Package_)
+       pkg_find_replace(
+         file.path("R", "onLoad.R"),
+         sprintf('packageVersion\\("%s"\\)', old.Package),
+         sprintf('packageVersion\\("%s"\\)', new.Package))
+       pkg_find_replace(
+         file.path("src", "init.c"),
+         paste0("R_init_", Package_regex),
+         paste0("R_init_", gsub("[.]", "_", new.Package_)))
+       pkg_find_replace(
+         "NAMESPACE",
+         sprintf('useDynLib\\("?%s"?', Package_regex),
+         paste0('useDynLib(', new.Package_))
+     }),
+     commit.id = quote(list("Before"="be2f72e6f5c90622fe72e1c315ca05769a9dc854",
+                      "Regression"="e793f53466d99f86e70fc2611b708ae8c601a451", 
+                      "Fixed"="58409197426ced4714af842650b0cc3b9e2cb842")),
+     N = quote(10^seq(3, 8)),
+     expr = quote(data.table:::`[.data.table`(dt, , .(vs = (sum(val))), by = .(id))),
+     setup = quote({
+       set.seed(123L)
+       dt <- data.table(
+         id = seq_len(N),
+         val = rnorm(N))
+       dt
+     })
+   ),
+   Memrecycle =  list(
+     pkg.edit.fun=quote(function(old.Package, new.Package, sha, new.pkg.path){
+       
+       pkg_find_replace <- function(glob, FIND, REPLACE){
+         atime::glob_find_replace(file.path(new.pkg.path, glob), FIND, REPLACE)
+       }
+       Package_regex <- gsub(".", "_?", old.Package, fixed=TRUE)
+       Package_ <- gsub(".", "_", old.Package, fixed=TRUE)
+       new.Package_ <- paste0(Package_, "_", sha)
+       
+       pkg_find_replace(
+         "DESCRIPTION",
+         paste0("Package:\\s+", old.Package),
+         paste("Package:", new.Package))
+       pkg_find_replace(
+         file.path("src","Makevars.*in"),
+         Package_regex,
+         new.Package_)
+       pkg_find_replace(
+         file.path("R", "onLoad.R"),
+         Package_regex,
+         new.Package_)
+       pkg_find_replace(
+         file.path("R", "onLoad.R"),
+         sprintf('packageVersion\\("%s"\\)', old.Package),
+         sprintf('packageVersion\\("%s"\\)', new.Package))
+       pkg_find_replace(
+         file.path("src", "init.c"),
+         paste0("R_init_", Package_regex),
+         paste0("R_init_", gsub("[.]", "_", new.Package_)))
+       pkg_find_replace(
+         "NAMESPACE",
+         sprintf('useDynLib\\("?%s"?', Package_regex),
+         paste0('useDynLib(', new.Package_))
+     }),
+     commit.id = quote(list("Before"="be2f72e6f5c90622fe72e1c315ca05769a9dc854",
+                      "Regression"="e793f53466d99f86e70fc2611b708ae8c601a451", 
+                      "Fixed"="58409197426ced4714af842650b0cc3b9e2cb842")),
+     N = quote(10^seq(3, 8)),
+     expr = quote(data.table:::`[.data.table`(dt, , .(vs = sum(v)),by = id)),
+     setup = quote({
+       set.seed(1)
+       d1 <- abs(rnorm(N, sd = 4))
+       d2 <- as.integer(cumsum(d1))
+       tm <- as.POSIXct("2020-01-01 09:30:00") + d2
+       nIds <- 3
+       tmCol <- rep(tm, nIds)
+       idCol <- rep(c("a", "b", "c"), N)
+       dt <- data.table(tm = tmCol, v = 1)
+       dt[, id := idCol]
+       dt[, tm1 := tm - 40]
+       dt[, tm2 := tm]
+       dt[, rowNum := .I]
+     })
+   ),
+   groupbywithdogroups = list(
+     pkg.edit.fun=quote(function(old.Package, new.Package, sha, new.pkg.path){
+       
+       pkg_find_replace <- function(glob, FIND, REPLACE){
+         atime::glob_find_replace(file.path(new.pkg.path, glob), FIND, REPLACE)
+       }
+       Package_regex <- gsub(".", "_?", old.Package, fixed=TRUE)
+       Package_ <- gsub(".", "_", old.Package, fixed=TRUE)
+       new.Package_ <- paste0(Package_, "_", sha)
+       
+       pkg_find_replace(
+         "DESCRIPTION",
+         paste0("Package:\\s+", old.Package),
+         paste("Package:", new.Package))
+       pkg_find_replace(
+         file.path("src","Makevars.*in"),
+         Package_regex,
+         new.Package_)
+       pkg_find_replace(
+         file.path("R", "onLoad.R"),
+         Package_regex,
+         new.Package_)
+       pkg_find_replace(
+         file.path("R", "onLoad.R"),
+         sprintf('packageVersion\\("%s"\\)', old.Package),
+         sprintf('packageVersion\\("%s"\\)', new.Package))
+       pkg_find_replace(
+         file.path("src", "init.c"),
+         paste0("R_init_", Package_regex),
+         paste0("R_init_", gsub("[.]", "_", new.Package_)))
+       pkg_find_replace(
+         "NAMESPACE",
+         sprintf('useDynLib\\("?%s"?', Package_regex),
+         paste0('useDynLib(', new.Package_))
+     }),
+     commit.id = quote(list("Before"="15f0598b9828d3af2eb8ddc9b38e0356f42afe4f",
+                       "Regression"="6f360be0b2a6cf425f6df751ca9a99ec5d35ed93", 
+                       "Fixed"="ba32f3cba38ec270587e395f6e6c26a80be36be6")),
+     N = quote(10^seq(3, 8)),
+     expr = quote(data.table:::`[.data.table`(d, , (max(v1)-min(v2)), by = id3)),
+     setup = quote({
+       set.seed(108)
+       d <- data.table(
+         id3 = sample(c(seq.int(N*0.9), sample(N*0.9, N*0.1, TRUE))),
+         v1 = sample(5L, N, TRUE),
+         v2 = sample(5L, N, TRUE))
+     })
+   )
+   
+ )
> 
> atime::atime_pkg("C:/Users/Doris Afriyie/data.table4test/") 
Error in if (sha == "") { : the condition has length > 1

[tdhock]

first of all please remove quote when it is not necessary (pkg.edit.fun)
second of all, is pkg.edit.fun the same for every test? if so please define it once, and use that variable in each test (atime_grid or for loop?), instead of repeating the same code over and over again for each test (which is confusing, makes the reader think there may be differences between the different pkg.edit funs).
finally what is the following code doing? I suspect that is the cause of your error,

+     commit.id = quote(list("Before"="15f0598b9828d3af2eb8ddc9b38e0356f42afe4f",
+                       "Regression"="6f360be0b2a6cf425f6df751ca9a99ec5d35ed93", 
+                       "Fixed"="ba32f3cba38ec270587e395f6e6c26a80be36be6")),

each item in test.list should be a list of arguments to pass to atime_versions, and commit.id is not a recognized argument name.

[tdhock]

when I run that code I get the following error message,

> atime::atime_pkg("~/R/data.table")
Error in get_sha_vec(sha.vec, dots.vec) : 
  each ... argument value and sha.vec element must be a string (package version, length=1, not NA), problems: commit.id
> sessionInfo()
R version 4.3.2 (2023-10-31 ucrt)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 19045)

Matrix products: default


locale:
[1] LC_COLLATE=English_United States.utf8 
[2] LC_CTYPE=English_United States.utf8   
[3] LC_MONETARY=English_United States.utf8
[4] LC_NUMERIC=C                          
[5] LC_TIME=English_United States.utf8    

time zone: America/Phoenix
tzcode source: internal

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] data.table_1.14.9

loaded via a namespace (and not attached):
[1] compiler_4.3.2  atime_2023.12.7 tools_4.3.2     grid_4.3.2     
[5] git2r_0.33.0    lattice_0.22-5 

[DorisAmoakohene]

@tdhock I think I fixed it

see the plot below

[tdhock]

great, glad you fixed it.
the first two tests look reasonable (regression slower than others), but the second two do not.

• test.name: Memrecycle shows Regression same as others, but should be slower than Before.
• test.name: Significantrolling has no line for regression, but it does look slower for N=1000. To get a line, try some smaller N values (10, 50, 100, etc)
  Also can you please use dots or underscores in test names? Change Significantrolling to Significant_rolling

[DorisAmoakohene]

@tdhock
well noted
let me work on that