fix(signer): exclude background AUTH signs from the approval wait

NIP-42 relay AUTH (kind 22242) and NIP-98 HTTP auth (kind 27235) flow through the
same signer.signEvent chokepoint as user posts, so the new withSignerApproval
wrapper was surfacing a "Waiting for signer approval" toast and a 30s timeout for
every background relay-AUTH sign — noisy on a multi-relay deck, and it rejected
AUTH signs the user never meant to approve (observed live: "subscribe auth
function failed: Signer did not respond in time").

Pass the draft kind through to withSignerApproval and pass auth kinds straight
through with no toast and no timeout, reverting AUTH to its prior behavior. Real
user-initiated signs still get the waiting indicator + bound. Adds a unit test.

Found in browser smoke against a real Clave bunker.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: DocNR

src/lib/__tests__/signer-approval.spec.ts

@@ -0,0 +1,51 @@
+import { kinds } from 'nostr-tools'
+import { afterEach, describe, expect, it, vi } from 'vitest'
+import { toast } from 'sonner'
+import { withSignerApproval } from '../signer-approval'
+
+// signer-approval imports sonner (for the waiting toast) and @/i18n (for copy).
+// Mock both so the module is testable in the node env and we can assert whether
+// the toast was scheduled.
+vi.mock('sonner', () => ({ toast: { loading: vi.fn(), dismiss: vi.fn() } }))
+vi.mock('@/i18n', () => ({ default: { t: (key: string) => key } }))
+
+describe('withSignerApproval', () => {
+  afterEach(() => {
+    vi.mocked(toast.loading).mockClear()
+    vi.mocked(toast.dismiss).mockClear()
+  })
+
+  it('passes NIP-42 relay AUTH (kind 22242) straight through with no toast', async () => {
+    const result = await withSignerApproval(Promise.resolve('signed'), kinds.ClientAuth)
+    expect(result).toBe('signed')
+    expect(toast.loading).not.toHaveBeenCalled()
+  })
+
+  it('passes NIP-98 HTTP AUTH (kind 27235) straight through with no toast', async () => {
+    const result = await withSignerApproval(Promise.resolve('signed'), kinds.HTTPAuth)
+    expect(result).toBe('signed')
+    expect(toast.loading).not.toHaveBeenCalled()
+  })
+
+  it('does not apply the approval timeout to background AUTH signs', async () => {
+    // A never-resolving AUTH sign must not be rejected by the timeout: it is
+    // returned verbatim. Race it against a short sentinel — the sentinel wins,
+    // proving withSignerApproval did not reject it at the (tiny) timeout.
+    const never = new Promise<string>(() => {})
+    const sentinel = new Promise<string>((resolve) => setTimeout(() => resolve('sentinel'), 30))
+    const winner = await Promise.race([withSignerApproval(never, kinds.ClientAuth, 5), sentinel])
+    expect(winner).toBe('sentinel')
+  })
+
+  it('still enforces the timeout for a normal user-initiated sign (kind 1)', async () => {
+    const never = new Promise<string>(() => {})
+    await expect(withSignerApproval(never, 1, 20)).rejects.toThrow('Signer did not respond in time')
+  })
+
+  it('resolves a normal sign and shows then dismisses nothing for an instant resolve', async () => {
+    const result = await withSignerApproval(Promise.resolve('ok'), 1)
+    expect(result).toBe('ok')
+    // Instant resolve beats the 1s show delay, so the loading toast never fires.
+    expect(toast.loading).not.toHaveBeenCalled()
+  })
+})

src/lib/signer-approval.ts

@@ -1,4 +1,5 @@
 import i18n from '@/i18n'
+import { kinds } from 'nostr-tools'
 import { toast } from 'sonner'
 
 // Signers that require manual approval — NIP-46 remote signers (bunker /
@@ -19,6 +20,14 @@ const SHOW_DELAY_MS = 1000
 const TIMEOUT_MS = 30_000
 const TOAST_ID = 'signer-approval-waiting'
 
+// NIP-42 relay AUTH (kind 22242) and NIP-98 HTTP AUTH (kind 27235) are signed
+// automatically in the background — relay-connection AUTH, media-upload and
+// translation HTTP auth — never as a user-initiated action. They must not surface
+// an approval-wait toast or be bounded by the user-approval timeout: an AUTH-gated
+// relay the user never manually approves would otherwise spam the toast and reject
+// every background AUTH at the 30s mark.
+const BACKGROUND_SIGN_KINDS = new Set<number>([kinds.ClientAuth, kinds.HTTPAuth])
+
 let pending = 0
 let timer: ReturnType<typeof setTimeout> | null = null
 let shown = false
@@ -47,7 +56,15 @@ function hide() {
   }
 }
 
-export async function withSignerApproval<T>(promise: Promise<T>, timeout = TIMEOUT_MS): Promise<T> {
+export async function withSignerApproval<T>(
+  promise: Promise<T>,
+  kind?: number,
+  timeout = TIMEOUT_MS
+): Promise<T> {
+  // Background auth signs pass straight through — no toast, no timeout.
+  if (kind !== undefined && BACKGROUND_SIGN_KINDS.has(kind)) {
+    return promise
+  }
   if (pending === 0) {
     scheduleShow()
   }

src/providers/NostrProvider/bunker.signer.ts

@@ -119,7 +119,7 @@ export class BunkerSigner implements ISigner {
     if (!this.signer) {
       throw new Error('Not logged in')
     }
-    return withSignerApproval(this.signer.signEvent(draftEvent))
+    return withSignerApproval(this.signer.signEvent(draftEvent), draftEvent.kind)
   }
 
   async nip04Encrypt(pubkey: string, plainText: string) {

src/providers/NostrProvider/nip-07.signer.ts

@@ -36,7 +36,7 @@ export class Nip07Signer implements ISigner {
     if (!this.signer) {
       throw new Error('Should call init() first')
     }
-    return await withSignerApproval(this.signer.signEvent(draftEvent))
+    return await withSignerApproval(this.signer.signEvent(draftEvent), draftEvent.kind)
   }
 
   async nip04Encrypt(pubkey: string, plainText: string) {