This repository was archived by the owner on May 21, 2020. It is now read-only.
[RFC] Discount getters#407
Open
andrzejewsky wants to merge 2 commits into
Open
Conversation
Collaborator
andrzejewsky
commented
Apr 17, 2020
andrzejewsky
commented
- I'm confirming that if i made any changes to public APIs or exposed any public APIs they are doccumented.
filrak
reviewed
Apr 23, 2020
| getDiscountedTotals: () => AgnosticTotals; | ||
| getDiscountName: () => string; | ||
| getDiscountValue: () => number; | ||
| getDiscountType: () => string; // fixed or percentage |
| getDiscountId: () => string; | ||
| getDiscountedTotals: () => AgnosticTotals; | ||
| getDiscountName: () => string; | ||
| getDiscountValue: () => number; |
Contributor
There was a problem hiding this comment.
should return string eg "-15%" "-20 złotych"
| Also I'm thinking about separated getters, which has even more sense as you can have multiple discounts applied to the cart. | ||
|
|
||
| ```ts | ||
| export interface DiscountGetters { |
Contributor
There was a problem hiding this comment.
Can be different between platforms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.