Weird incompatibility with world generation

[xAlicatt]

I have tested this with minimal mods and it's for sure an incompatibility with JEIDs and Chunk Pregenerator mod pregeneration. This is using the preview button method of pregeneration (on the world creation screen). I have not tested with the in-game command pregen. (edited to reflect updated understanding of the issue)

Basically the biomes are generating weirdly. The biome features all exist as normal, but the actual biome is almost all plains. There is a random chunk here and there that will have the proper biome, but over 90% of the map will generate with the biome ID being Plains. I've included a picture to better explain what i'm talking about, and I've seen you ask for logs, so those are here

[ZombieHDGaming]

There's not really much I can do since ChunkPregenerator is closed source (I don't see what the point is of it being closed source). If you bring it to Speiger's attention, I'd be willing to work with him to make it compatible, but like I said, there's not much I can go off of based on a mod that I would have to decompile, which would be worst case scenario. Bring it to his attention and we'll go from there.

[SalmonSays]

I've noticed this same issue and didn't realize it was tied to JEIDs- my test environments have all included a beta terrain-height/noise modifier so I wrongly assumed the blame was there.

The same bug happens with Forge's built in pregeneration ("/forge generate") so I'm hopeful you won't need to see Chunk Pregenerator's source to fix this- the bug is identical between the two, so fixing it for Forge will probably fix it for ChunkPregenerator.

Quick Edit: To build off of xAlicatt, I have tested using the in-game commands of Forge and ChunkPregenerator to the same effect. The key thing about this issue is that it only happens when pre-generating; Exploring the terrain naturally on a client or server/client results in terrain that behaves exactly as it's supposed to.

[xAlicatt]

I'm wondering if it's the default world generator that causes it? A fellow modpack maker has tested pregen with BOP's generator and says this does not happen.

EDIT:: The friend was using NEIDs, not JEIDs

[SalmonSays]

It's not exclusively default world generation, in that a private build of RTG behaves the same way. I'm interested to see that you got unusual chunk borders in your sample photos in addition to the plains biome, because I ran into those too:

It means not only are biome distributions being impacted, but chunks are being built wrong in seemingly random places in ways that don't match a corresponding naturally generated world-seed.

[Speiger]

Well ChunkPregen calls basically the same methodes as minecraft does, just with its own wrappers.
But the functions are basically 99% identical.
I basically do the same thing as "ChunkProviderServer.provideChunk" does @xAlicatt @ZombieHDGaming
And thats my only connection to worldgen, everything else is basically done by minecraft itself.

I can provide more detail info on this if you have more questions.

On a Educated guess: Does a mod in this pack change the rule how chunks have to be populated/generated?
Because this looks like something RTG did, that mod is basically incompatible to any Pregenerator, because it changes the population from 2x2 to 3x3 which makes me wonder if its even compatible to mc.

[xAlicatt]

@Speiger I have tested this with VERY minimal mods. Just Enough IDs, Chunk Pregenerator, Thaumcraft (to check for modded biome support), Hwyla, and JEI. I'm using vanilla generation. With JEIDs, I get this weird biome ID situation using pregen. Without JEIDs, it works as expected. With JEIDs, loading chunks as normal (without pregen) works as expected.

It's a conflict between pregeneration and JEIDs.

Edit: Basically, i don't think it has anything to do with your mod specifically, but sharing your code with @ZombieHDGaming may help him fix it.

Edit Again: So I just tested with BOP and it's still doing this. It's something to do with pregeneration versus normal generation.

[Andyghandi]

Can't believe i found the root for this problem. It drove me crazy! Hoping for a solution soon

[Andyghandi]

I can confirm that the issue remains even with quark's realistic gen

[Speiger]

@Andyghandi what was it?
@xAlicatt i already did tell what code i use for it, basically the same as forges just with a customized wrapper that allows me to control crashes better so that the tool can restart quicker.

[Andyghandi]

@Speiger Sorry, I didn't mean like I found the bug, more like I found the issue for my world generating in all plains. In Journeymap, I can see the biomes name, even though the chunks are discovered, it's like, an 8 chunk radius out from the player makes a plains biome, and outside this 8 chunk radius, It displays the proper biome names on journeymap's full-screen map

[Speiger]

@ZombieHDGaming @xAlicatt
the issue is in this class:
https://github.com/DimensionalDevelopment/JustEnoughIDs/blob/master/src/main/java/org/dimdev/jeid/mixin/core/MixinChunk.java

You change the function getBiome to only have integers, using your intArray, thats fine (ignoring all the incompat you get by everything that uses the getBiomeArray byteversion)
but your "getBiome" function does not account for if a biome is "uninitialized" which minecraft handles and also tries to regenerate that area in the biome generator if needed.
I think thats the bug where the biomes are not generated properly and that could be an issue.

I bet that pregenerated worlds are not "PlainsOnly" but only the client side of things receives that kind of data.

Its a wonder that my tool didnt crash ^^"

[Speiger]

anything happend or no time or ignoring it until it disapears?

[SalmonSays]

@ZombieHDGaming This should probably be switched from the "incompatibility" label to the "bug" one since it happens with the built-in Forge chunk pregen system