Skip to content

DataGrid - Fix incorrect onFocusedCellChanged parameters when focusing the first cell (T1282664) #32814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markallenramirez wants to merge 5 commits into
base: 26_1
Choose a base branch
from
Open

DataGrid - Fix incorrect onFocusedCellChanged parameters when focusing the first cell (T1282664) #32814

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e288738
fix
markallenramirez Mar 6, 2026
5c08f3b
Revert "fix"
markallenramirez Mar 6, 2026
36428f2
fix2
markallenramirez Mar 6, 2026
df6fa2c
Revert "fix2"
markallenramirez Mar 11, 2026
fc51146
fix parameter
markallenramirez Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ges/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ export class KeyboardNavigationController extends KeyboardNavigationControllerCo
const isCell = $element.is('td');
const needSetFocusPosition = (this.option('focusedRowIndex') ?? -1) < 0;
if (isCell && needSetFocusPosition) {
this._focusView();
this._updateFocusedCellPosition($element);
}
Comment on lines 241 to 244
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change modifies focus behavior when a cell receives focus while focusedRowIndex is not set (< 0). There doesn’t appear to be a regression test that covers focusing a td in this state and asserting that keyboard navigation initializes its focused view correctly (and doesn’t throw / mis-handle subsequent focus updates). Please add a test (likely in packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/focus.tests.js or keyboardNavigation.keyboardController.tests.js) that triggers focusin on a data cell with focusedRowIndex: -1/undefined and validates the expected focus state.

Copilot uses AI. Check for mistakes.
}
Expand Down
Loading