Skip to content

Commit 6fbc970

Browse files
Fix CI detection operator and remove unused parameter in Node runner (#32809)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nightskylark <2280467+nightskylark@users.noreply.github.com>
1 parent 1986572 commit 6fbc970

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

packages/devextreme/testing/runner/index.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -335,8 +335,7 @@ async function handleRequest(req: http.IncomingMessage, res: http.ServerResponse
335335
if (req.method === 'GET') {
336336
const executeConsoleAppMatch = /^\/TestVectorMapData\/ExecuteConsoleApp(?:\/(.*))?$/i.exec(pathname);
337337
if (executeConsoleAppMatch) {
338-
const arg = safeDecodeURIComponent(executeConsoleAppMatch[1] || '');
339-
const result = vectorMapService.executeVectorMapConsoleApp(arg, requestUrl.searchParams);
338+
const result = vectorMapService.executeVectorMapConsoleApp(requestUrl.searchParams);
340339
sendJson(res, result);
341340
return;
342341
}

packages/devextreme/testing/runner/lib/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ export function formatDateForSuiteTimestamp(date: Date): string {
114114
}
115115

116116
export function isContinuousIntegration(): boolean {
117-
return Boolean(process.env.CCNetWorkingDirectory ?? process.env.DEVEXTREME_TEST_CI);
117+
return Boolean(process.env.CCNetWorkingDirectory || process.env.DEVEXTREME_TEST_CI);
118118
}
119119

120120
export function resolveNodePath(): string {

packages/devextreme/testing/runner/lib/vectormap.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ interface VectorMapServiceOptions {
2323
}
2424

2525
export interface VectorMapService {
26-
executeVectorMapConsoleApp: (arg: string, searchParams: URLSearchParams) => VectorMapOutputItem[];
26+
executeVectorMapConsoleApp: (searchParams: URLSearchParams) => VectorMapOutputItem[];
2727
readThemeCssFiles: () => string[];
2828
readVectorMapTestData: () => VectorMapDataItem[];
2929
redirectRequestToVectorMapNodeServer: (action: string, arg: string) => Promise<string>;
@@ -231,7 +231,6 @@ export function createVectorMapService({
231231
}
232232

233233
function executeVectorMapConsoleApp(
234-
arg: string,
235234
searchParams: URLSearchParams,
236235
): VectorMapOutputItem[] {
237236
const inputDirectory = `${path.join(packageRoot, 'testing', 'content', 'VectorMapData')}${path.sep}`;

0 commit comments

Comments
 (0)