PG: Add per index blocks hit and blocks read #20767
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonnefoa
force-pushed
the
pg-index-block-usage
branch
from
173e9ed to
a0eca4a
Compare
nenadnoveljic
previously approved these changes
Jul 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
pg_statio_user_indexes provides per index block usage. It is using pg_stat_get_blocks_fetched and pg_stat_get_blocks_hit behind the hood. We can emit those metrics directly from our IDX_METRICS query. The metric name index.blocks_read was used as index_blocks_read already exists for the per table block usage.
WAL metrics presence are already covered in common pg integration tests
bonnefoa
force-pushed
the
pg-index-block-usage
branch
from
a0eca4a to
7d0e0c2
Compare
temporal-github-worker-1
bot
dismissed
nenadnoveljic’s stale review
Review from nenadnoveljic is dismissed. Related teams and files:
- database-monitoring-agent
- postgres/changelog.d/20767.added
- postgres/datadog_checks/postgres/relationsmanager.py
- postgres/metadata.csv
- postgres/tests/test_pg_integration.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
pg_statio_user_indexesprovides per index block usage. It is usingpg_stat_get_blocks_fetchedandpg_stat_get_blocks_hitbehind the hood. We can emit those metrics directly from our IDX_METRICS query.The metric name
postgresql.index.blocks_readwas used aspostgresql.index_blocks_readalready exists for the per table block usage.Motivation
This would provide a better granularity of the index block usage.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged