Skip to content

Build system tests service images #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lloeki
Copy link
Member

@lloeki lloeki commented Jan 23, 2025

What does this PR do?

Build system tests service images

Motivation:

Hoists non-GH service image pulling out of test jobs

Change log entry

None.

Additional Notes:

How to test the change?

@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Jan 23, 2025
Copy link

github-actions bot commented Jan 23, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-01-23 12:58:35 UTC

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.62%. Comparing base (c6e0d59) to head (e84091c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4314      +/-   ##
==========================================
- Coverage   97.64%   97.62%   -0.02%     
==========================================
  Files        1474     1476       +2     
  Lines       88059    88066       +7     
  Branches     4569     4569              
==========================================
- Hits        85983    85974       -9     
- Misses       2076     2092      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lloeki lloeki marked this pull request as ready for review June 17, 2025 09:13
@lloeki lloeki requested a review from a team as a code owner June 17, 2025 09:13
Hoists non-GH service image pulling out of test jobs
@lloeki lloeki force-pushed the lloeki/build-system-tests-service-images branch from acabb06 to c894e44 Compare June 17, 2025 09:15
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jun 17, 2025

Datadog Report

Branch report: lloeki/build-system-tests-service-images
Commit report: e84091c
Test service: dd-trace-rb

✅ 0 Failed, 21719 Passed, 1299 Skipped, 4m 45.89s Total Time

@p-datadog
Copy link
Member

p-datadog commented Jun 17, 2025

Any thoughts on this failure?


Run docker push ghcr.io/datadog/dd-trace-rb/system-tests/ruby/weblog-rack:gha15711215207-ge1fc0bf9bbb8e290963a3ef597153ee0948cfe9e
The push refers to repository [ghcr.io/datadog/dd-trace-rb/system-tests/ruby/weblog-rack]
e919d[8](https://github.com/DataDog/dd-trace-rb/actions/runs/15711215207/job/44269535380?pr=4314#step:10:9)8e5c65: Preparing
d63cf6234270: Preparing
d00d19cfd14f: Preparing
dc0f7dd6099d: Preparing
3e[9](https://github.com/DataDog/dd-trace-rb/actions/runs/15711215207/job/44269535380?pr=4314#step:10:10)b4e508c70: Preparing
5f70bf18a086: Preparing
05ac0a75a55a: Preparing
75f25ec17771: Preparing
[12](https://github.com/DataDog/dd-trace-rb/actions/runs/15711215207/job/44269535380?pr=4314#step:10:13)4ef1cff6d4: Preparing
3e194cc50a14: Preparing
c3418ec05412: Preparing
5951bad0d52b: Preparing
b958446a86ea: Preparing
8d09f49431c3: Preparing
c79764ad9d4c: Preparing
270e52a41512: Preparing
e7a4de3076af: Preparing
e5c4da516043: Preparing
d259a0833d41: Preparing
8074245e25ed: Preparing
71e1aa306a5a: Preparing
69f16cc74eb0: Preparing
82677505c894: Preparing
5f70bf18a086: Waiting
05ac0a75a55a: Waiting
75f25ec17771: Waiting
124ef1cff6d4: Waiting
3e194cc50a[14](https://github.com/DataDog/dd-trace-rb/actions/runs/15711215207/job/44269535380?pr=4314#step:10:15): Waiting
c3418ec05412: Waiting
5951bad0d52b: Waiting
b958446a86ea: Waiting
8d09f49431c3: Waiting
8074245e25ed: Waiting
71e1aa306a5a: Waiting
c79764ad9d4c: Waiting
69f16cc74eb0: Waiting
82677505c894: Waiting
270e52a4[15](https://github.com/DataDog/dd-trace-rb/actions/runs/15711215207/job/44269535380?pr=4314#step:10:16)12: Waiting
e7a4de3076af: Waiting
d259a0833d41: Waiting
e5c4da5[16](https://github.com/DataDog/dd-trace-rb/actions/runs/15711215207/job/44269535380?pr=4314#step:10:17)043: Waiting
3e9b4e508c70: Layer already exists
5f70bf18a086: Layer already exists
05ac0a75a55a: Layer already exists
75f25ec[17](https://github.com/DataDog/dd-trace-rb/actions/runs/15711215207/job/44269535380?pr=4314#step:10:18)771: Layer already exists
124ef1cff6d4: Layer already exists
3e194cc50a14: Layer already exists
e919d88e5c65: Pushed
d63cf6234270: Pushed
b958446a86ea: Layer already exists
c34[18](https://github.com/DataDog/dd-trace-rb/actions/runs/15711215207/job/44269535380?pr=4314#step:10:19)ec05412: Layer already exists
5951bad0d52b: Layer already exists
8d09f49431c3: Layer already exists
c79764ad9d4c: Layer already exists
270e52a41512: Layer already exists
d259a0833d41: Layer already exists
dc0f7dd6099d: Pushed
8074245e25ed: Layer already exists
e5c4da516043: Layer already exists
71e1aa306a5a: Layer already exists
69f16cc74eb0: Layer already exists
e7a4de3076af: Layer already exists
82677505c894: Layer already exists
d00d[19](https://github.com/DataDog/dd-trace-rb/actions/runs/15711215207/job/44269535380?pr=4314#step:10:20)cfd14f: Pushed
Head "https://ghcr.io/v2/datadog/dd-trace-rb/system-tests/ruby/weblog-rack/blobs/sha256:514239e69ed96b3c35[21](https://github.com/DataDog/dd-trace-rb/actions/runs/15711215207/job/44269535380?pr=4314#step:10:22)d071d78e0fa048d34df61e35f8a8b1dd07fb7a79dfab": EOF
Error: Process completed with exit code 1.

https://github.com/DataDog/dd-trace-rb/actions/runs/15711215207/job/44269535380?pr=4314

@pr-commenter
Copy link

pr-commenter bot commented Jun 17, 2025

Benchmarks

Benchmark execution time: 2025-06-17 15:45:22

Comparing candidate commit e84091c in PR branch lloeki/build-system-tests-service-images with baseline commit c6e0d59 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 6 unstable metrics.

scenario:line instrumentation - targeted

  • 🟩 throughput [+10700.411op/s; +11241.735op/s] or [+6.712%; +7.052%]

scenario:method instrumentation

  • 🟩 throughput [+10800.880op/s; +11371.734op/s] or [+6.429%; +6.769%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants