From 892f9828e58592223fcb3add60b2bc57ba32397c Mon Sep 17 00:00:00 2001 From: Fayssal Defaa Date: Tue, 31 Mar 2026 09:01:23 +0200 Subject: [PATCH 1/2] update slos --- ...-runner.macrobenchmarks.fail-on-breach.yml | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/.gitlab/benchmarks/bp-runner.macrobenchmarks.fail-on-breach.yml b/.gitlab/benchmarks/bp-runner.macrobenchmarks.fail-on-breach.yml index 3c3955b28a0..71381748fb9 100644 --- a/.gitlab/benchmarks/bp-runner.macrobenchmarks.fail-on-breach.yml +++ b/.gitlab/benchmarks/bp-runner.macrobenchmarks.fail-on-breach.yml @@ -1,6 +1,15 @@ -# Example of measurements can be seen here: https://benchmarking.us1.prod.dog/benchmarks?benchmarkGroupPipelineId=66629462&benchmarkGroupSha=16054515e292a66c5eaf79b9ea62df6f348cd67e&page=1&ciJobDateStart=1746309551994&ciJobDateEnd=1748901551994&benchmarkId=14167634 - -# Thresholds set based on guidance in https://datadoghq.atlassian.net/wiki/spaces/APMINT/pages/5070193198/How+to+set+up+pre-release+performance+quality+gates#How-to-choose-thresholds-for-pre-release-gates%3F +# Auto-generated SLO Thresholds +# Generated: 2026-03-31 +# +# Generation Strategy: tight +# Formula: CI_bound / (1 ± T) (T = 5.0%) +# +# SLO Checking: +# - BREACH: 90% CI boundary crosses threshold +# - WARNING: 90% CI boundary crosses warning_threshold (constant) +# +# DO NOT EDIT MANUALLY - Regenerate using: +# benchmark_analyzer generate slos --help experiments: - name: Run SLO breach check @@ -24,7 +33,7 @@ experiments: - agg_http_req_duration_p95 < 100 ms - name: high_load/tracing-rc-enabled-telemetry-enabled thresholds: - - throughput > 45.0 op/s + - throughput > 51.625 op/s - agg_http_req_duration_p99 < 100 ms # Appsec - name: normal_operation/appsec-enabled-iast-disabled-ep-disabled @@ -46,7 +55,7 @@ experiments: - rss < 1040 MB - name: high_load/tracing-profiling-enabled thresholds: - - throughput > 30.0 op/s + - throughput > 49.938 op/s - agg_http_req_duration_p99 < 110 ms # Multi-product - name: normal_operation/vuln-appsec-disabled-iast-enabled-ep-disabled-profiling-enabled From 323a7fce1bb4e2f7dc9b42bfa8a8751c9781ce06 Mon Sep 17 00:00:00 2001 From: Fayssal Defaa Date: Tue, 31 Mar 2026 14:39:00 +0200 Subject: [PATCH 2/2] add slo generation docs --- .gitlab/benchmarks/bp-runner.macrobenchmarks.fail-on-breach.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab/benchmarks/bp-runner.macrobenchmarks.fail-on-breach.yml b/.gitlab/benchmarks/bp-runner.macrobenchmarks.fail-on-breach.yml index 71381748fb9..44ae23bbbe1 100644 --- a/.gitlab/benchmarks/bp-runner.macrobenchmarks.fail-on-breach.yml +++ b/.gitlab/benchmarks/bp-runner.macrobenchmarks.fail-on-breach.yml @@ -11,6 +11,8 @@ # DO NOT EDIT MANUALLY - Regenerate using: # benchmark_analyzer generate slos --help +# link to documentation on autogenerated thresholds https://github.com/DataDog/relenv-benchmark-analyzer/blob/main/README.md#generate-slo-thresholds + experiments: - name: Run SLO breach check steps: