-
Notifications
You must be signed in to change notification settings - Fork 312
Fix proxy settings for maven smoke tests #9099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 10 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~d0b8bb8ed6, baseline=1.51.0-SNAPSHOT~33422a3a65
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.006 s) : 0, 1005958
Total [baseline] (8.599 s) : 0, 8599361
Agent [candidate] (996.366 ms) : 0, 996366
Total [candidate] (8.577 s) : 0, 8577140
section iast
Agent [baseline] (1.135 s) : 0, 1135341
Total [baseline] (9.269 s) : 0, 9268534
Agent [candidate] (1.14 s) : 0, 1139805
Total [candidate] (9.322 s) : 0, 9321643
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~d0b8bb8ed6, baseline=1.51.0-SNAPSHOT~33422a3a65
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.129 ms) : 0, 695129
BytebuddyAgent [candidate] (688.754 ms) : 0, 688754
GlobalTracer [baseline] (244.138 ms) : 0, 244138
GlobalTracer [candidate] (241.8 ms) : 0, 241800
AppSec [baseline] (30.579 ms) : 0, 30579
AppSec [candidate] (30.147 ms) : 0, 30147
Debugger [baseline] (6.102 ms) : 0, 6102
Debugger [candidate] (6.021 ms) : 0, 6021
Remote Config [baseline] (683.513 µs) : 0, 684
Remote Config [candidate] (686.779 µs) : 0, 687
Telemetry [baseline] (8.335 ms) : 0, 8335
Telemetry [candidate] (8.163 ms) : 0, 8163
section iast
BytebuddyAgent [baseline] (809.135 ms) : 0, 809135
BytebuddyAgent [candidate] (814.181 ms) : 0, 814181
GlobalTracer [baseline] (233.089 ms) : 0, 233089
GlobalTracer [candidate] (234.335 ms) : 0, 234335
IAST [baseline] (24.814 ms) : 0, 24814
IAST [candidate] (29.736 ms) : 0, 29736
AppSec [baseline] (31.298 ms) : 0, 31298
AppSec [candidate] (26.155 ms) : 0, 26155
Debugger [baseline] (7.5 ms) : 0, 7500
Debugger [candidate] (5.887 ms) : 0, 5887
Remote Config [baseline] (588.438 µs) : 0, 588
Remote Config [candidate] (581.047 µs) : 0, 581
Telemetry [baseline] (8.06 ms) : 0, 8060
Telemetry [candidate] (8.036 ms) : 0, 8036
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~d0b8bb8ed6, baseline=1.51.0-SNAPSHOT~33422a3a65
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.003 s) : 0, 1003345
Total [baseline] (10.652 s) : 0, 10652319
Agent [candidate] (997.711 ms) : 0, 997711
Total [candidate] (10.649 s) : 0, 10648524
section appsec
Agent [baseline] (1.175 s) : 0, 1174539
Total [baseline] (10.8 s) : 0, 10800459
Agent [candidate] (1.181 s) : 0, 1180570
Total [candidate] (10.72 s) : 0, 10719952
section iast
Agent [baseline] (1.133 s) : 0, 1132613
Total [baseline] (10.856 s) : 0, 10856167
Agent [candidate] (1.134 s) : 0, 1134411
Total [candidate] (10.872 s) : 0, 10871864
section profiling
Agent [baseline] (1.263 s) : 0, 1263041
Total [baseline] (11.069 s) : 0, 11068513
Agent [candidate] (1.248 s) : 0, 1247946
Total [candidate] (11.066 s) : 0, 11066209
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~d0b8bb8ed6, baseline=1.51.0-SNAPSHOT~33422a3a65
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.295 ms) : 0, 693295
BytebuddyAgent [candidate] (688.821 ms) : 0, 688821
GlobalTracer [baseline] (243.396 ms) : 0, 243396
GlobalTracer [candidate] (242.729 ms) : 0, 242729
AppSec [baseline] (30.664 ms) : 0, 30664
AppSec [candidate] (30.44 ms) : 0, 30440
Debugger [baseline] (6.063 ms) : 0, 6063
Debugger [candidate] (6.05 ms) : 0, 6050
Remote Config [baseline] (688.871 µs) : 0, 689
Remote Config [candidate] (675.973 µs) : 0, 676
Telemetry [baseline] (8.32 ms) : 0, 8320
Telemetry [candidate] (8.253 ms) : 0, 8253
section appsec
BytebuddyAgent [baseline] (710.323 ms) : 0, 710323
BytebuddyAgent [candidate] (715.786 ms) : 0, 715786
GlobalTracer [baseline] (234.529 ms) : 0, 234529
GlobalTracer [candidate] (235.716 ms) : 0, 235716
IAST [baseline] (23.129 ms) : 0, 23129
IAST [candidate] (21.999 ms) : 0, 21999
AppSec [baseline] (171.287 ms) : 0, 171287
AppSec [candidate] (171.617 ms) : 0, 171617
Debugger [baseline] (5.735 ms) : 0, 5735
Debugger [candidate] (5.806 ms) : 0, 5806
Remote Config [baseline] (604.499 µs) : 0, 604
Remote Config [candidate] (599.793 µs) : 0, 600
Telemetry [baseline] (8.052 ms) : 0, 8052
Telemetry [candidate] (8.106 ms) : 0, 8106
section iast
BytebuddyAgent [baseline] (807.337 ms) : 0, 807337
BytebuddyAgent [candidate] (809.769 ms) : 0, 809769
GlobalTracer [baseline] (232.717 ms) : 0, 232717
GlobalTracer [candidate] (233.74 ms) : 0, 233740
IAST [baseline] (28.562 ms) : 0, 28562
IAST [candidate] (25.554 ms) : 0, 25554
AppSec [baseline] (28.741 ms) : 0, 28741
AppSec [candidate] (30.009 ms) : 0, 30009
Debugger [baseline] (5.813 ms) : 0, 5813
Debugger [candidate] (5.836 ms) : 0, 5836
Remote Config [baseline] (587.31 µs) : 0, 587
Remote Config [candidate] (633.46 µs) : 0, 633
Telemetry [baseline] (8.032 ms) : 0, 8032
Telemetry [candidate] (7.97 ms) : 0, 7970
section profiling
BytebuddyAgent [baseline] (688.078 ms) : 0, 688078
BytebuddyAgent [candidate] (680.274 ms) : 0, 680274
GlobalTracer [baseline] (366.308 ms) : 0, 366308
GlobalTracer [candidate] (362.386 ms) : 0, 362386
AppSec [baseline] (32.711 ms) : 0, 32711
AppSec [candidate] (30.895 ms) : 0, 30895
Debugger [baseline] (12.048 ms) : 0, 12048
Debugger [candidate] (11.397 ms) : 0, 11397
Remote Config [baseline] (679.027 µs) : 0, 679
Remote Config [candidate] (1.458 ms) : 0, 1458
Telemetry [baseline] (8.087 ms) : 0, 8087
Telemetry [candidate] (9.479 ms) : 0, 9479
ProfilingAgent [baseline] (105.295 ms) : 0, 105295
ProfilingAgent [candidate] (103.346 ms) : 0, 103346
Profiling [baseline] (105.319 ms) : 0, 105319
Profiling [candidate] (103.371 ms) : 0, 103371
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~d0b8bb8ed6, baseline=1.51.0-SNAPSHOT~33422a3a65
dateFormat X
axisFormat %s
section baseline
no_agent (4.327 ms) : 4277, 4376
. : milestone, 4327,
iast (9.06 ms) : 8915, 9205
. : milestone, 9060,
iast_FULL (14.079 ms) : 13801, 14358
. : milestone, 14079,
iast_GLOBAL (10.248 ms) : 10059, 10436
. : milestone, 10248,
profiling (8.759 ms) : 8616, 8901
. : milestone, 8759,
tracing (7.825 ms) : 7715, 7935
. : milestone, 7825,
section candidate
no_agent (4.312 ms) : 4258, 4366
. : milestone, 4312,
iast (9.093 ms) : 8937, 9249
. : milestone, 9093,
iast_FULL (13.691 ms) : 13417, 13966
. : milestone, 13691,
iast_GLOBAL (9.77 ms) : 9594, 9946
. : milestone, 9770,
profiling (8.808 ms) : 8655, 8961
. : milestone, 8808,
tracing (7.73 ms) : 7620, 7839
. : milestone, 7730,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~d0b8bb8ed6, baseline=1.51.0-SNAPSHOT~33422a3a65
dateFormat X
axisFormat %s
section baseline
no_agent (37.984 ms) : 37674, 38295
. : milestone, 37984,
appsec (48.029 ms) : 47597, 48462
. : milestone, 48029,
code_origins (45.423 ms) : 45027, 45819
. : milestone, 45423,
iast (43.914 ms) : 43526, 44301
. : milestone, 43914,
profiling (48.501 ms) : 48039, 48963
. : milestone, 48501,
tracing (43.394 ms) : 43026, 43762
. : milestone, 43394,
section candidate
no_agent (36.038 ms) : 35742, 36334
. : milestone, 36038,
appsec (45.74 ms) : 45332, 46147
. : milestone, 45740,
code_origins (44.15 ms) : 43774, 44525
. : milestone, 44150,
iast (44.121 ms) : 43733, 44508
. : milestone, 44121,
profiling (47.444 ms) : 47014, 47874
. : milestone, 47444,
tracing (43.857 ms) : 43480, 44235
. : milestone, 43857,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~d0b8bb8ed6, baseline=1.51.0-SNAPSHOT~33422a3a65
dateFormat X
axisFormat %s
section baseline
no_agent (14.981 s) : 14981000, 14981000
. : milestone, 14981000,
appsec (14.72 s) : 14720000, 14720000
. : milestone, 14720000,
iast (18.409 s) : 18409000, 18409000
. : milestone, 18409000,
iast_GLOBAL (17.996 s) : 17996000, 17996000
. : milestone, 17996000,
profiling (15.12 s) : 15120000, 15120000
. : milestone, 15120000,
tracing (15.114 s) : 15114000, 15114000
. : milestone, 15114000,
section candidate
no_agent (15.005 s) : 15005000, 15005000
. : milestone, 15005000,
appsec (14.849 s) : 14849000, 14849000
. : milestone, 14849000,
iast (18.59 s) : 18590000, 18590000
. : milestone, 18590000,
iast_GLOBAL (17.816 s) : 17816000, 17816000
. : milestone, 17816000,
profiling (15.156 s) : 15156000, 15156000
. : milestone, 15156000,
tracing (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~d0b8bb8ed6, baseline=1.51.0-SNAPSHOT~33422a3a65
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.41 ms) : 2360, 2459
. : milestone, 2410,
iast (2.184 ms) : 2122, 2246
. : milestone, 2184,
iast_GLOBAL (2.251 ms) : 2188, 2314
. : milestone, 2251,
profiling (2.034 ms) : 1984, 2084
. : milestone, 2034,
tracing (2.023 ms) : 1974, 2071
. : milestone, 2023,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.416 ms) : 2366, 2465
. : milestone, 2416,
iast (2.183 ms) : 2122, 2245
. : milestone, 2183,
iast_GLOBAL (2.241 ms) : 2178, 2303
. : milestone, 2241,
profiling (2.489 ms) : 2314, 2664
. : milestone, 2489,
tracing (2.027 ms) : 1978, 2076
. : milestone, 2027,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Does This Do
The existing proxy settings using
<repository>
does not work for maven versions > 3.8.0 . In those versions, maven rejects repositories using thehttp
protocol. Instead, the correct way is to use a<mirror>
.Because mirrors can't be activated with a maven profile, the mirror settings are conditionally added to the command line if the
MAVEN_REPOSITORY_PROXY
environment variable existsMotivation
Increased stability and speed of the maven smoke tests
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]