Add error priorities for dynamic instrumentation and manual instrumentation #9098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @deejgregor Thanks for having opened this pull request. Having one more level for manual instrumentation makes sense. I think there is no need to create an additional one for the TagInterceptor, since the setError here uses the default (That will be lower of the one created for manual instrumentation). |
amarziali
added
type: enhancement
amarziali
reviewed
Jul 8, 2025
| @@ -217,7 +217,7 @@ private boolean interceptDbStatement(DDSpanContext span, Object value) { | |||
| } | |||
|
|
|||
| private boolean interceptError(DDSpanContext span, Object value) { | |||
| span.setErrorFlag(asBoolean(value), ErrorPriorities.DEFAULT); | |||
| span.setErrorFlag(asBoolean(value), ErrorPriorities.TAG_INTERCEPTOR); | |||
There was a problem hiding this comment.
I would still use the default here. The ones using the interceptor, are setting a tag to infer the error flag.Both are falling hence into the manual instrumentation use case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds error priorities for dynamic instrumentation and manual instrumentation, similar to what exists for priorities for resource name today.
It also sets the priority for manual instrumentation from otel spans for both resource name and error.
Motivation
Reliably override error status set by automatic instrumentation from dynamic instrumentation and manual instrumentation.
Additional Notes
No tests have been added yet. If the change generally seems good, I'm happy to write tests.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]