-
Notifications
You must be signed in to change notification settings - Fork 312
Change Sonatype names to Maven Central #9079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~947a0b4668, baseline=1.51.0-SNAPSHOT~8aa9607a21
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (995.267 ms) : 0, 995267
Total [baseline] (10.644 s) : 0, 10643926
Agent [candidate] (996.958 ms) : 0, 996958
Total [candidate] (10.647 s) : 0, 10646647
section appsec
Agent [baseline] (1.184 s) : 0, 1184436
Total [baseline] (10.79 s) : 0, 10790488
Agent [candidate] (1.186 s) : 0, 1186371
Total [candidate] (10.825 s) : 0, 10825207
section iast
Agent [baseline] (1.133 s) : 0, 1132801
Total [baseline] (10.86 s) : 0, 10860366
Agent [candidate] (1.142 s) : 0, 1142015
Total [candidate] (10.933 s) : 0, 10933104
section profiling
Agent [baseline] (1.265 s) : 0, 1265467
Total [baseline] (11.103 s) : 0, 11102534
Agent [candidate] (1.247 s) : 0, 1246936
Total [candidate] (10.938 s) : 0, 10937546
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~947a0b4668, baseline=1.51.0-SNAPSHOT~8aa9607a21
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.717 ms) : 0, 686717
BytebuddyAgent [candidate] (687.875 ms) : 0, 687875
GlobalTracer [baseline] (242.39 ms) : 0, 242390
GlobalTracer [candidate] (243.058 ms) : 0, 243058
AppSec [baseline] (30.359 ms) : 0, 30359
AppSec [candidate] (30.25 ms) : 0, 30250
Debugger [baseline] (6.077 ms) : 0, 6077
Debugger [candidate] (6.055 ms) : 0, 6055
Remote Config [baseline] (690.09 µs) : 0, 690
Remote Config [candidate] (690.715 µs) : 0, 691
Telemetry [baseline] (8.28 ms) : 0, 8280
Telemetry [candidate] (8.225 ms) : 0, 8225
section appsec
BytebuddyAgent [baseline] (715.968 ms) : 0, 715968
BytebuddyAgent [candidate] (717.754 ms) : 0, 717754
GlobalTracer [baseline] (237.112 ms) : 0, 237112
GlobalTracer [candidate] (237.324 ms) : 0, 237324
IAST [baseline] (23.57 ms) : 0, 23570
IAST [candidate] (23.459 ms) : 0, 23459
AppSec [baseline] (172.475 ms) : 0, 172475
AppSec [candidate] (172.275 ms) : 0, 172275
Debugger [baseline] (5.737 ms) : 0, 5737
Debugger [candidate] (5.836 ms) : 0, 5836
Remote Config [baseline] (600.359 µs) : 0, 600
Remote Config [candidate] (601.444 µs) : 0, 601
Telemetry [baseline] (8.023 ms) : 0, 8023
Telemetry [candidate] (8.137 ms) : 0, 8137
section iast
BytebuddyAgent [baseline] (807.729 ms) : 0, 807729
BytebuddyAgent [candidate] (814.567 ms) : 0, 814567
GlobalTracer [baseline] (232.511 ms) : 0, 232511
GlobalTracer [candidate] (234.461 ms) : 0, 234461
IAST [baseline] (28.755 ms) : 0, 28755
IAST [candidate] (28.881 ms) : 0, 28881
AppSec [baseline] (28.547 ms) : 0, 28547
AppSec [candidate] (28.786 ms) : 0, 28786
Debugger [baseline] (5.899 ms) : 0, 5899
Debugger [candidate] (5.832 ms) : 0, 5832
Remote Config [baseline] (579.94 µs) : 0, 580
Remote Config [candidate] (592.657 µs) : 0, 593
Telemetry [baseline] (7.983 ms) : 0, 7983
Telemetry [candidate] (7.973 ms) : 0, 7973
section profiling
BytebuddyAgent [baseline] (688.901 ms) : 0, 688901
BytebuddyAgent [candidate] (678.663 ms) : 0, 678663
GlobalTracer [baseline] (366.593 ms) : 0, 366593
GlobalTracer [candidate] (362.42 ms) : 0, 362420
AppSec [baseline] (32.792 ms) : 0, 32792
AppSec [candidate] (31.058 ms) : 0, 31058
Debugger [baseline] (11.627 ms) : 0, 11627
Debugger [candidate] (12.144 ms) : 0, 12144
Remote Config [baseline] (678.582 µs) : 0, 679
Remote Config [candidate] (659.837 µs) : 0, 660
Telemetry [baseline] (8.96 ms) : 0, 8960
Telemetry [candidate] (9.564 ms) : 0, 9564
ProfilingAgent [baseline] (106.766 ms) : 0, 106766
ProfilingAgent [candidate] (103.902 ms) : 0, 103902
Profiling [baseline] (106.791 ms) : 0, 106791
Profiling [candidate] (103.927 ms) : 0, 103927
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~947a0b4668, baseline=1.51.0-SNAPSHOT~8aa9607a21
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.003 s) : 0, 1003194
Total [baseline] (8.61 s) : 0, 8609553
Agent [candidate] (1.003 s) : 0, 1002583
Total [candidate] (8.616 s) : 0, 8616006
section iast
Agent [baseline] (1.135 s) : 0, 1135444
Total [baseline] (9.282 s) : 0, 9282482
Agent [candidate] (1.14 s) : 0, 1139734
Total [candidate] (9.324 s) : 0, 9324048
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~947a0b4668, baseline=1.51.0-SNAPSHOT~8aa9607a21
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.731 ms) : 0, 693731
BytebuddyAgent [candidate] (693.43 ms) : 0, 693430
GlobalTracer [baseline] (243.114 ms) : 0, 243114
GlobalTracer [candidate] (242.957 ms) : 0, 242957
AppSec [baseline] (30.274 ms) : 0, 30274
AppSec [candidate] (30.382 ms) : 0, 30382
Debugger [baseline] (6.071 ms) : 0, 6071
Debugger [candidate] (6.126 ms) : 0, 6126
Remote Config [baseline] (676.061 µs) : 0, 676
Remote Config [candidate] (680.778 µs) : 0, 681
Telemetry [baseline] (8.502 ms) : 0, 8502
Telemetry [candidate] (8.185 ms) : 0, 8185
section iast
BytebuddyAgent [baseline] (809.727 ms) : 0, 809727
BytebuddyAgent [candidate] (813.061 ms) : 0, 813061
GlobalTracer [baseline] (232.728 ms) : 0, 232728
GlobalTracer [candidate] (233.587 ms) : 0, 233587
IAST [baseline] (27.206 ms) : 0, 27206
IAST [candidate] (27.221 ms) : 0, 27221
AppSec [baseline] (29.692 ms) : 0, 29692
AppSec [candidate] (30.577 ms) : 0, 30577
Debugger [baseline] (6.754 ms) : 0, 6754
Debugger [candidate] (5.849 ms) : 0, 5849
Remote Config [baseline] (572.803 µs) : 0, 573
Remote Config [candidate] (577.53 µs) : 0, 578
Telemetry [baseline] (7.947 ms) : 0, 7947
Telemetry [candidate] (7.939 ms) : 0, 7939
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~947a0b4668, baseline=1.51.0-SNAPSHOT~8aa9607a21
dateFormat X
axisFormat %s
section baseline
no_agent (36.692 ms) : 36397, 36988
. : milestone, 36692,
appsec (47.543 ms) : 47118, 47969
. : milestone, 47543,
code_origins (44.505 ms) : 44107, 44903
. : milestone, 44505,
iast (44.27 ms) : 43883, 44658
. : milestone, 44270,
profiling (49.881 ms) : 49416, 50347
. : milestone, 49881,
tracing (43.534 ms) : 43172, 43897
. : milestone, 43534,
section candidate
no_agent (35.926 ms) : 35639, 36213
. : milestone, 35926,
appsec (47.844 ms) : 47408, 48279
. : milestone, 47844,
code_origins (45.838 ms) : 45435, 46241
. : milestone, 45838,
iast (44.03 ms) : 43637, 44423
. : milestone, 44030,
profiling (47.769 ms) : 47342, 48196
. : milestone, 47769,
tracing (45.622 ms) : 45240, 46005
. : milestone, 45622,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~947a0b4668, baseline=1.51.0-SNAPSHOT~8aa9607a21
dateFormat X
axisFormat %s
section baseline
no_agent (4.42 ms) : 4371, 4469
. : milestone, 4420,
iast (9.156 ms) : 9009, 9303
. : milestone, 9156,
iast_FULL (13.7 ms) : 13434, 13966
. : milestone, 13700,
iast_GLOBAL (10.233 ms) : 10056, 10411
. : milestone, 10233,
profiling (8.575 ms) : 8427, 8723
. : milestone, 8575,
tracing (7.818 ms) : 7688, 7947
. : milestone, 7818,
section candidate
no_agent (4.414 ms) : 4363, 4464
. : milestone, 4414,
iast (9.343 ms) : 9191, 9495
. : milestone, 9343,
iast_FULL (13.517 ms) : 13249, 13786
. : milestone, 13517,
iast_GLOBAL (10.532 ms) : 10347, 10717
. : milestone, 10532,
profiling (8.513 ms) : 8370, 8657
. : milestone, 8513,
tracing (7.576 ms) : 7462, 7690
. : milestone, 7576,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~947a0b4668, baseline=1.51.0-SNAPSHOT~8aa9607a21
dateFormat X
axisFormat %s
section baseline
no_agent (14.9 s) : 14900000, 14900000
. : milestone, 14900000,
appsec (14.804 s) : 14804000, 14804000
. : milestone, 14804000,
iast (18.551 s) : 18551000, 18551000
. : milestone, 18551000,
iast_GLOBAL (17.769 s) : 17769000, 17769000
. : milestone, 17769000,
profiling (15.298 s) : 15298000, 15298000
. : milestone, 15298000,
tracing (14.926 s) : 14926000, 14926000
. : milestone, 14926000,
section candidate
no_agent (15.525 s) : 15525000, 15525000
. : milestone, 15525000,
appsec (15.014 s) : 15014000, 15014000
. : milestone, 15014000,
iast (18.505 s) : 18505000, 18505000
. : milestone, 18505000,
iast_GLOBAL (17.777 s) : 17777000, 17777000
. : milestone, 17777000,
profiling (15.58 s) : 15580000, 15580000
. : milestone, 15580000,
tracing (14.958 s) : 14958000, 14958000
. : milestone, 14958000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~947a0b4668, baseline=1.51.0-SNAPSHOT~8aa9607a21
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.403 ms) : 2353, 2452
. : milestone, 2403,
iast (2.181 ms) : 2120, 2243
. : milestone, 2181,
iast_GLOBAL (2.227 ms) : 2165, 2289
. : milestone, 2227,
profiling (2.465 ms) : 2246, 2685
. : milestone, 2465,
tracing (1.999 ms) : 1951, 2047
. : milestone, 1999,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.397 ms) : 2347, 2446
. : milestone, 2397,
iast (2.185 ms) : 2123, 2247
. : milestone, 2185,
iast_GLOBAL (2.235 ms) : 2173, 2298
. : milestone, 2235,
profiling (2.05 ms) : 1999, 2101
. : milestone, 2050,
tracing (2.0 ms) : 1952, 2048
. : milestone, 2000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's merge after release just to be safe.
And probably we also need to rename secrets names in secrets storage....
What Does This Do
Changes a few
sonatype
namings tomaven central
Motivation
Update our naming, now that we are publishing to the Maven Central repository (#8807).
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/LANGPLAT-493