-
Notifications
You must be signed in to change notification settings - Fork 29
Robot Upgrade: gpu-operator chart upgrade from v25.3.0 to v25.10.0 #3701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @weizhoublue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant version upgrade for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades the gpu-operator Helm chart from v25.3.0 to v25.10.0. The changes primarily involve version bumps across various configuration files and sub-charts, along with updates to reflect new features and configurations in the upgraded dependencies, such as node-feature-discovery. While most of the changes are straightforward dependency updates, I've identified a few areas with incorrect YAML templating that could lead to deployment failures. My review includes suggestions to fix these templating issues to ensure the chart is valid and robust.
| {{- with .Values.master.extraEnvs }} | ||
| {{- toYaml . | nindent 8 }} | ||
| {{- toYaml . | nindent 10 }} | ||
| {{- end}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extraEnvs block is incorrectly placed and indented, which will result in an invalid YAML structure. It should be placed inside the env list of the container definition. This change corrects the placement and indentation to ensure that extraEnvs are properly appended to the container's environment variables.
env:
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
{{- with .Values.master.extraEnvs }}
{{- toYaml . | nindent 10 }}
{{- end }}
| imagePullPolicy: {{ .Values.operator.imagePullPolicy }} | ||
| command: | ||
| - /bin/sh | ||
| - sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| imagePullPolicy: {{ .Values.operator.imagePullPolicy }} | ||
| command: | ||
| - /bin/sh | ||
| - sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4c59744 to
d275249
Compare
09d52dd to
fe968de
Compare
0bef275 to
98ad774
Compare
5b347b6 to
c2159b2
Compare
5eebeb3 to
ef4c8ce
Compare
Signed-off-by: robot <[email protected]>
ef4c8ce to
364f880
Compare
I am robot, upgrade: project gpu-operator chart upgrade from v25.3.0 to v25.10.0