-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Description
When changing the logging system in drunc to include the other streams such as ERS and Opmon, there are several handlers defined there that have not been created already. These include:
- lstdout
- Basically just thread safe stdout handler. We decided that we should just fall back to using the known stdout handler, but we should discuss how its going to be used. eg if lstdout is stdout or if we want there to be two separate LoggerHandler.StdOut instances, one for the normal stdout and one for the lstdout. These would have implications on how the code is written
- throttle
- A method that limits the amount of messages that are transmitted. For example, if there are 1000 errors being generated in drunc, throttle will allow it so that only 10 of them get transmitted, and the rest are truncated
- https://github.com/DUNE-DAQ/ers?tab=readme-ov-file#existing-stream-implementations
- ERSTrace
- To be further studied- After discussion, ERS Trace does not need to be implemented
These need to be defined and implemented in the relevant repositories, probably daqpytools
At some point, the protobuf implementation should also be reviewed, as currently it is hardcoded to only use the default options (monkafka.cern.ch:30092, ers_stream) and no further checks have been done. We should discuss if we even want to support multiple protobuf handlers with differing urls / ports / topics. Superseded by #41
Potential impact radius
Small/Isolated
Reason for change
No response
Suggested implementations
No response
Testing suggestions
No response
Anything else?
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request