Removing the possibility for custom getDIRACPlatform(s) method ?

[simon-mazenoux]

Currently, the getDIRACPlatform and getDIRACPlatforms methods can be VO specific :

In the JobDB class (getDIRACPlatform) :

 # loading the function that will be used to determine the platform (it can be VO specific)
res = ObjectLoader().loadObject("ConfigurationSystem.Client.Helpers.Resources", "getDIRACPlatform")
if not res["OK"]:
    self.log.fatal(res["Message"])
self.getDIRACPlatform = res["Value"]

In the Job class (getDIRACPlatforms):

# loading the function that will be used to determine the platform (it can be VO specific)
res = ObjectLoader().loadObject("ConfigurationSystem.Client.Helpers.Resources", "getDIRACPlatforms")
if not res["OK"]:
    self.log.fatal(res["Message"])
self.getDIRACPlatforms = res["Value"]

These two methods are used to check if the specified platform is correct :

In the JobDB class:

    platformList = classAdJob.getListFromExpression("Platform")
    if platformList:
        result = self.getDIRACPlatform(platformList)
        if not result["OK"]:
            return result

In the Job class:

        if not platform.lower() == "any":
            availablePlatforms = self.getDIRACPlatforms()
            if not availablePlatforms["OK"]:
                return self._reportError("Can't check for platform", **kwargs)
            if platform in availablePlatforms["Value"]:
                self._addParameter(self.workflow, "Platform", "JDL", platform, "Platform ( Operating System )")
            else:
                return self._reportError("Invalid platform", **kwargs)

This use case for a custom getDIRACPlatform and getDIRACPlatforms methods were introduced for LHCbDIRAC, but is no longer necessary for that specific VO.

I was therefore wondering if this possibility for customization was currently used by another VO, and, if not, can be removed by importing the method directly :

In the JobDB class:

from DIRAC.ConfigurationSystem.Client.Helpers.Resources import getDIRACPlatform

    platformList = classAdJob.getListFromExpression("Platform")
    if platformList:
        result = getDIRACPlatform(platformList)
        if not result["OK"]:
            return result

In the Job class:

from DIRAC.ConfigurationSystem.Client.Helpers.Resources import getDIRACPlatforms

availablePlatforms = getDIRACPlatforms()

[andresailer]

Can you write the after of the code to understand which feature you are going to remove?

[andresailer]

Thanks for the update.
We don't have a custom getDIRACPlatform in iLCDirac.

[hmiyake]

Sorry for late reply.
Belle2 does not use getDIRACPlatform(s) in our extension.