apply review suggestions for compose stability and test coverage

Author: GREENRAT-K405

concore_cli/commands/build.py

@@ -97,18 +97,17 @@ def _write_docker_compose(output_path):
         "services:",
     ]
 
-    prev_service_name = None
     named_volumes = set()
     for index, service in enumerate(services, start=1):
         service_name = re.sub(r"[^A-Za-z0-9_.-]", "-", service["container_name"]).strip(
             "-."
         )
         if not service_name:
             service_name = f"service-{index}"
-        elif not service_name[0].isalnum():
+        elif not service_name[0].isalpha():
             service_name = f"service-{service_name}"
 
-        compose_lines.append(f"  {service_name}:")
+        compose_lines.append(f"  {_yaml_quote(service_name)}:")
         compose_lines.append(f"    image: {_yaml_quote(service['image'])}")
         compose_lines.append(
             f"    container_name: {_yaml_quote(service['container_name'])}"
@@ -117,11 +116,6 @@ def _write_docker_compose(output_path):
         compose_lines.append("    networks:")
         compose_lines.append("      - concore-net")
 
-        # Chain services sequentially to prevent ZMQ race conditions
-        if prev_service_name:
-            compose_lines.append("    depends_on:")
-            compose_lines.append(f"      - {prev_service_name}")
-
         if service["volumes"]:
             compose_lines.append("    volumes:")
             for volume_spec in service["volumes"]:
@@ -130,7 +124,6 @@ def _write_docker_compose(output_path):
                 if re.match(r"^[a-zA-Z0-9_-]+$", part1):
                     named_volumes.add(part1)
 
-        prev_service_name = service_name
 
     if named_volumes:
         compose_lines.append("")
@@ -219,22 +212,24 @@ def build_workflow(
                 elif (output_path / "src").exists():
                     req_dest.touch()
 
-                # Append requirement copying to generated scripts
+                # Append requirement copying to generated scripts robustly
                 for s_name in ["build", "build.bat"]:
                     s_path = output_path / s_name
                     if s_path.exists():
                         content = s_path.read_text(encoding="utf-8")
+                        lines = content.splitlines()
                         if s_name == "build":
-                            content = content.replace(
-                                "docker build",
-                                "cp ../src/requirements.txt .\ndocker build",
-                            )
+                            insert_line = "cp ../src/requirements.txt ."
                         else:
-                            content = content.replace(
-                                "docker build",
-                                "copy ..\\src\\requirements.txt .\n    docker build",
-                            )
-                        s_path.write_text(content, encoding="utf-8")
+                            insert_line = "copy ..\\src\\requirements.txt ."
+
+                        new_lines = []
+                        for line in lines:
+                            if " build" in line and "-t " in line:
+                                new_lines.append(insert_line)
+                            new_lines.append(line)
+
+                        s_path.write_text("\n".join(new_lines) + "\n", encoding="utf-8")
 
             if result.stdout:
                 console.print(result.stdout)

tests/test_cli.py

@@ -383,6 +383,10 @@ def test_build_command_docker_compose_single_node(self):
             self.assertIn("services:", compose_content)
             self.assertIn("container_name: 'N1'", compose_content)
             self.assertIn("image: 'docker-script'", compose_content)
+            self.assertIn("networks:", compose_content)
+            self.assertIn("concore-net:", compose_content)
+            self.assertIn("- concore-net", compose_content)
+            self.assertIn("restart: on-failure", compose_content)
 
             metadata = json.loads(Path("out/STUDY.json").read_text())
             self.assertIn("docker-compose.yml", metadata["checksums"])
@@ -431,6 +435,35 @@ def test_build_command_docker_compose_multi_node(self):
             self.assertIn("container_name: 'C'", compose_content)
             self.assertIn("image: 'docker-common'", compose_content)
 
+    def test_build_command_docker_requirements_injection(self):
+        with self.runner.isolated_filesystem(temp_dir=self.temp_dir):
+            result = self.runner.invoke(cli, ["init", "test-project"])
+            self.assertEqual(result.exit_code, 0)
+
+            Path("requirements.txt").write_text("pandas==1.0.0")
+
+            result = self.runner.invoke(
+                cli,
+                [
+                    "build",
+                    "test-project/workflow.graphml",
+                    "--source",
+                    "test-project/src",
+                    "--output",
+                    "out",
+                    "--type",
+                    "docker",
+                ],
+            )
+            self.assertEqual(result.exit_code, 0)
+
+            req_path = Path("out/src/requirements.txt")
+            self.assertTrue(req_path.exists())
+            self.assertEqual(req_path.read_text(), "pandas==1.0.0")
+
+            build_script = Path("out/build").read_text()
+            self.assertIn("cp ../src/requirements.txt .", build_script)
+
     def test_build_command_shared_source_specialization_merges_edge_params(self):
         with self.runner.isolated_filesystem(temp_dir=self.temp_dir):
             Path("src").mkdir()