fixes to MutableBytes.set for empty structures

Author: lu-pinto

bytes/src/main/java/org/apache/tuweni/bytes/v2/MutableBytes.java

@@ -294,6 +294,9 @@ public static MutableBytes of(int... bytes) {
    */
   public void set(int index, Bytes bytes) {
     checkNotNull(bytes);
+    if (bytes.isEmpty()) {
+      return;
+    }
     checkElementIndex(index, length);
     checkArgument(
         index + bytes.size() <= length,
@@ -316,6 +319,9 @@ public void set(int index, Bytes bytes) {
    */
   public void set(int index, byte[] bytes) {
     checkNotNull(bytes);
+    if (bytes.length == 0) {
+      return;
+    }
     checkElementIndex(index, length);
     checkArgument(
         index + bytes.length <= length,
@@ -378,6 +384,24 @@ public void setLong(int index, long value) {
     set(index, (byte) (value & 0xFF));
   }
 
+  /**
+   * Set a byte in this value.
+   *
+   * @param index The index of the byte to set.
+   * @param b The value to set that byte to.
+   * @throws IndexOutOfBoundsException if {@code i < 0} or {i >= size()}.
+   */
+  public void set(int index, byte b) {
+    checkElementIndex(index, length);
+    if (index > (length - 1)) {
+      throw new IndexOutOfBoundsException(
+              format(
+                      "Value of size %s has not enough bytes to write a 4 bytes int from index %s",
+                      length, index));
+    }
+    bytesArray[offset + index] = b;
+  }
+
   /**
    * Increments the value of the bytes by 1, treating the value as big endian.
    *
@@ -724,17 +748,6 @@ public int size() {
     return length;
   }
 
-  /**
-   * Set a byte in this value.
-   *
-   * @param i The index of the byte to set.
-   * @param b The value to set that byte to.
-   * @throws IndexOutOfBoundsException if {@code i < 0} or {i >= size()}.
-   */
-  public void set(int i, byte b) {
-    bytesArray[offset + i] = b;
-  }
-
   @Override
   public byte get(int i) {
     return bytesArray[offset + i];

devp2p/src/test/kotlin/org/apache/tuweni/devp2p/v5/internal/DefaultAuthenticationProviderTest.kt

@@ -51,7 +51,7 @@ class DefaultAuthenticationProviderTest {
 //    val ephemeralKeyPair = SECP256K1.KeyPair.random()
 //    val ephemeralKey = ephemeralKeyPair.secretKey()
 //
-//    val signValue = Bytes.concatenate(Bytes.wrap("discovery-id-nonce".toByteArray()), nonce)
+//    val signValue = Bytes.wrap(Bytes.wrap("discovery-id-nonce".toByteArray()), nonce)
 //    val hashedSignValue = Hash.sha2_256(signValue)
 //    val signature =  SECP256K1.sign(hashedSignValue, keyPair)
 //