Skip to content

Commit 1fa3035

Browse files
Merge pull request #216 from mpolgar/slightly_extra_logging
Add logging for changes made from /push endpoint
2 parents f149fbd + f9c45fb commit 1fa3035

2 files changed

Lines changed: 16 additions & 8 deletions

File tree

‎core/src/main/java/com/confighub/core/store/Store.java‎

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1981,6 +1981,8 @@ public void savePropertyKey( final String appIdentity,
19811981
{
19821982
validateWriteAccess( repository, token, propertyKey );
19831983
saveOrUpdateAuditedViaAPI( appIdentity, repository, propertyKey, changeComment );
1984+
1985+
log.info( "Updated property key for repository [%s] with key [%s]", repository.getName(), propertyKey.getKey() );
19841986
}
19851987

19861988

@@ -1993,6 +1995,12 @@ public void saveProperty( final String appIdentity,
19931995
{
19941996
validateWriteAccess( repository, token, property );
19951997
saveOrUpdateAuditedViaAPI( appIdentity, repository, property, changeComment );
1998+
1999+
log.info( "Updated property value > %s for repository [%s] and key [%s]: %s",
2000+
ContextParser.contextToString(property.getContext(), repository),
2001+
repository.getName(),
2002+
property.getPropertyKey().getKey(),
2003+
property.getValue() != null ? property.getValue().replace("\n", "\\n") : "" );
19962004
}
19972005

19982006

@@ -2056,7 +2064,7 @@ public Property createProperty( final String key,
20562064
propertyKey.setSecurityProfile( sp, spPassword );
20572065
}
20582066

2059-
log.info( "Added property for repository [%s] with key [%s]", repository.getName(), key );
2067+
log.info( "Added property key for repository [%s] with key [%s]", repository.getName(), key );
20602068
}
20612069

20622070
property.setPropertyKey( propertyKey );
@@ -2346,7 +2354,7 @@ public boolean deleteKeyAndProperties( final UserAccount user,
23462354
}
23472355

23482356
deleteAudited( user, repository, key );
2349-
log.info( "Deleted property for repository [%s] with key [%s]", repository.getName(), keyString );
2357+
log.info( "Deleted property key for repository [%s] with key [%s]", repository.getName(), keyString );
23502358
return true;
23512359
}
23522360

@@ -2392,7 +2400,7 @@ public boolean deleteKeyAndProperties( final String appIdentity,
23922400
}
23932401

23942402
deleteAuditedViaAPI( appIdentity, repository, key, changeComment );
2395-
log.info( "Deleted property for repository [%s] with key [%s]", repository.getName(), keyString );
2403+
log.info( "Deleted property key for repository [%s] with key [%s]", repository.getName(), keyString );
23962404
return true;
23972405
}
23982406

@@ -2455,7 +2463,7 @@ public boolean deleteProperty( final UserAccount user,
24552463
.size() == 0 ) )
24562464
{
24572465
ret &= deleteAudited( user, repository, propertyKey );
2458-
log.info( "Deleted property for repository [%s] with key [%s]", repository.getName(), key );
2466+
log.info( "Deleted property key for repository [%s] with key [%s]", repository.getName(), key );
24592467
}
24602468

24612469
return ret;
@@ -2505,7 +2513,7 @@ public boolean deleteProperty( final String appIdentity,
25052513
.size() == 0 ) )
25062514
{
25072515
ret &= deleteAuditedViaAPI( appIdentity, repository, propertyKey, changeComment );
2508-
log.info( "Deleted property for repository [%s] with key [%s]", repository.getName(), key );
2516+
log.info( "Deleted property key for repository [%s] with key [%s]", repository.getName(), key );
25092517
}
25102518

25112519
return ret;
@@ -2784,7 +2792,7 @@ public Pair<PropertyKey, KeyUpdateStatus> updatePropertyKey( final Repository re
27842792
validateWriteAccess( repository, user, propertyKey );
27852793
saveOrUpdateAudited( user, repository, propertyKey, changeComment );
27862794

2787-
log.info( "Added property for repository [%s] with key [%s]", repository.getName(), newKeyString );
2795+
log.info( "Added property key for repository [%s] with key [%s]", repository.getName(), newKeyString );
27882796

27892797
return new Pair<>( propertyKey, KeyUpdateStatus.UPDATE );
27902798
}
@@ -3276,7 +3284,7 @@ else if ( toSave.isSecure() )
32763284
deleteAudited( user, repository, toDelete, changeComment );
32773285
}
32783286

3279-
log.info( "Updated property for repository [%s] with key [%s]", repository.getName(), newKeyString );
3287+
log.info( "Updated property key for repository [%s] with key [%s]", repository.getName(), newKeyString );
32803288
return new Pair<>( toSave, status );
32813289
}
32823290

‎pom.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@
1616
<module>rest</module>
1717
</modules>
1818
<properties>
19-
<revision>1.10.5</revision>
19+
<revision>1.10.6</revision>
2020
</properties>
2121
</project>

0 commit comments

Comments
 (0)