Skip to content

Commit a08d34b

Browse files
committed
Add ability to pass --codesign-enabled to ./scripts/ci_build_windows.bat
1 parent e4d5263 commit a08d34b

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

docs/source/the-release-process.rst

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,7 @@ Creator, it's usually copied into a GitHub issue:
4141
the signed+notarized binaries instead. See OSC_CODESIGN_ENABLED and OSC_NOTARIZATION_ENABLED flags in the
4242
MacOS packaging. Adam Kewley specifically has the CMake flags, password, keys etc. necessary to do this.
4343
The process is: `./scripts/ci_build_mac-amd64.sh && rm build/opensimcreator-*.dmg && cmake -S . -B build $SIGNING_ARGS_FROM_KEYCHAIN && cmake --build build --target package`
44-
- [ ] For Windows, the release must be build ont a developer's machine, and the developer should configure the build with codesigning and
45-
upload the signed binaries. See `OSC_CODESIGN_ENABLED` flags in the Windows packaging directory.
44+
- [ ] For Windows, the release must be built on a developer's machine with `./scripts/ci_build_windows.bat --codesign-enabled`
4645
- [ ] Unzip/rename any artifacts (see prev. releases)
4746
- [ ] Create new release on github from the tagged commit
4847
- [ ] Upload all artifacts against it

scripts/ci_build_windows.bat

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
REM Performs an end-to-end CI build of OpenSim Creator.
33
REM This is what build agents should run to build release amd64 binaries of OpenSim Creator on Windows.
44

5-
REM Hide window creation in CI, because CI runners typically do not have a desktop environment.
6-
set "OSC_INTERNAL_HIDE_WINDOW=1"
7-
85
REM Ensure dependencies are re-checked/re-built if the CI script is run on
96
REM a potentially stale/cached workspace directory.
107
set "OSCDEPS_BUILD_ALWAYS=ON"
@@ -15,7 +12,7 @@ call scripts/env_vs.bat
1512
REM --system-version is necessary because, otherwise, the wrong Windows SDK might be chosen,
1613
REM resulting in either missing headers or shipping a binary that doesn't run on target systems.
1714
REM The specified SDK supports Windows 10, version 1507 or higher.
18-
python scripts\build_windows.py --system-version=10.0.26100.0 --generator=Ninja
15+
python scripts\build_windows.py --system-version=10.0.26100.0 --generator=Ninja %*
1916
if errorlevel 1 (
2017
echo Command failed with exit code %errorlevel%
2118
exit /b %errorlevel%

0 commit comments

Comments
 (0)