Skip to content

Revert "feat: add expires_in parameter to asset upload endpoints" - #109

Merged
wei-hai merged 1 commit into
mainfrom
revert-76-feat/asset-expiration
Aug 28, 2026
Merged

Revert "feat: add expires_in parameter to asset upload endpoints"#109
wei-hai merged 1 commit into
mainfrom
revert-76-feat/asset-expiration

Conversation

@wei-hai

@wei-hai wei-hai commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Reverts #76

Summary by CodeRabbit

  • Breaking Changes
    • Removed the expires_in option from asset upload and retrieval operations.
    • Removed the expires_in option from synchronous and asynchronous file-based asset creation.
    • Existing integrations passing expires_in must remove this parameter.

@wei-hai
wei-hai requested review from a team as code owners August 28, 2026 06:09
@wei-hai
wei-hai enabled auto-merge (squash) August 28, 2026 06:11
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 27dedb21-0ecd-448e-b8c3-87028b56224b

📥 Commits

Reviewing files that changed from the base of the PR and between 3b8753e and b8cfeeb.

📒 Files selected for processing (2)
  • src/comfy_low/transport.py
  • src/comfy_sdk/assets.py
 _________________________
< Will debug for carrots. >
 -------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-76-feat/asset-expiration

Comment @coderabbitai help to get the list of available commands.

@wei-hai
wei-hai merged commit 094f4eb into main Aug 28, 2026
10 of 11 checks passed
@wei-hai
wei-hai deleted the revert-76-feat/asset-expiration branch August 28, 2026 06:12
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants