made code great

Author: stesee

MencoderSharp/Mencoder.cs

@@ -10,7 +10,7 @@ public class Mencoder : MencoderBase
         /// <summary>
         /// The standard error
         /// </summary>
-        public string standardError;
+        public string StandardError { get; private set; }
 
         /// <summary>
         /// Mencoders the specified source.
@@ -43,7 +43,7 @@ public bool Mencode(string source, string destination, string videoParameter, st
                 process.StartInfo.CreateNoWindow = true;
                 process.StartInfo.Arguments = "\"" + source + "\" " + videoParameter + " " + audioParameter + " -o \"" + destination + "\"";
                 process.Start();
-                standardError = process.StandardError.ReadToEnd();
+                StandardError = process.StandardError.ReadToEnd();
                 process.WaitForExit();
                 return process.ExitCode.Equals(0);
             }

MencoderSharp/MencoderAsync.cs

@@ -17,7 +17,7 @@ public class MencoderAsync : MencoderBase
         /// <summary>
         /// Contains exitcode of mencoder and everything from standarderror
         /// </summary>
-        public MencoderResults Result;
+        public MencoderResults Result { get; private set; }
 
         //Backgroundworkerdocs:
         //http://msdn.microsoft.com/de-de/library/system.componentmodel.backgroundworker.aspx
@@ -26,7 +26,7 @@ public class MencoderAsync : MencoderBase
         /// <summary>
         /// The remember last line
         /// </summary>
-        private string rememberLastLine;
+        private string rememberLastLine = string.Empty;
 
         /// <summary>
         /// The standard error

MencoderSharpDemo/MencoderSharpDemo.cs

@@ -69,7 +69,6 @@ private void buttonStart_Click(object sender, EventArgs e)
             buttonStart.Enabled = false;
             progressBar1.Visible = true;
             mencoderAsync.StartEncodeAsync(labelSource.Text, labelDestinationPath.Text, textBoxVideoParameter.Text, textBoxAudioParamter.Text);
-            //mencoderAsync.startEncodeAsync(new Uri(labelSource.Text), new Uri(labelDestinationPath.Text));
         }
 
         /// <summary>
@@ -79,8 +78,8 @@ private void buttonStart_Click(object sender, EventArgs e)
         /// <param name="e">The <see cref="EventArgs" /> instance containing the event data.</param>
         private void MencoderSharpDemo_Load(object sender, EventArgs e)
         {
-            mencoderAsync.Finished += new EventHandler(mencoder_Finished);
-            mencoderAsync.ProgressChanged += new EventHandler(mencoder_Progress);
+            mencoderAsync.Finished += mencoder_Finished;
+            mencoderAsync.ProgressChanged += mencoder_Progress;
         }
 
         /// <summary>

MencoderSharpDemoImageToMovie/Form1.cs

@@ -80,8 +80,8 @@ private void buttonStart_Click(object sender, EventArgs e)
         /// <param name="e">The <see cref="EventArgs" /> instance containing the event data.</param>
         private void Form1_Load(object sender, EventArgs e)
         {
-            mencoderAsync.Finished += new EventHandler(mencoder_Finished);
-            mencoderAsync.ProgressChanged += new EventHandler(mencoder_Progress);
+            mencoderAsync.Finished += mencoder_Finished;
+            mencoderAsync.ProgressChanged += mencoder_Progress;
         }
 
         /// <summary>

MencoderSharpTest/MencoderSharpIntegrationTest.cs

@@ -25,8 +25,8 @@ public void ShouldStartEncodeAsync()
             asyncTaskRunning = false;
             using (var mencoderAsync = new MencoderSharp.MencoderAsync())
             {
-                mencoderAsync.Finished += new EventHandler(Mencoder_Finished);
-                mencoderAsync.ProgressChanged += new EventHandler(Mencoder_Progress);
+                mencoderAsync.Finished += Mencoder_Finished;
+                mencoderAsync.ProgressChanged += Mencoder_Progress;
                 mencoderAsync.StartEncodeAsync("./TestFiles/HelloWorld.avi", "./TestOutput.mp4");
                 asyncTaskRunning = true;
                 while (asyncTaskRunning)
@@ -44,8 +44,8 @@ public void ShouldStartEncodeSync()
             asyncTaskRunning = false;
             using (var mencoderAsync = new MencoderSharp.MencoderAsync())
             {
-                mencoderAsync.Finished += new EventHandler(Mencoder_Finished);
-                mencoderAsync.ProgressChanged += new EventHandler(Mencoder_Progress);
+                mencoderAsync.Finished += Mencoder_Finished;
+                mencoderAsync.ProgressChanged += Mencoder_Progress;
                 mencoderAsync.StartEncodeAsync("./TestFiles/small.mp4", "./SmallTestOutput.mp4");
                 asyncTaskRunning = true;
                 while (asyncTaskRunning)

README.md

@@ -19,9 +19,10 @@ Features:
 * Synchron or Asynchron executing
 * No Gui-Freezing in Asyncmode
 * Progress recognition of mencoder
-* Works on Win32 & Win64  
+* Comes with an mencoder bin that works on win32 & win64
+* Can make use of any mencoder bin in place (Windows & Linux)
 * mp4 / h.264 works fine
-* Streaming source from ftp, http, ...
+* Streaming source from ftp, http, ... (That was the reason I created this project)
 
 Sample:
 
@@ -37,8 +38,8 @@ private void buttonStart_Click(object sender, EventArgs e)
 
 private void MencoderSharpDemo_Load(object sender, EventArgs e)
 {
-    mencoderAsync.Finished += new EventHandler(this.mencoder_Finished);
-    mencoderAsync.ProgressChanged += new EventHandler(this.mencoder_Progress);
+    mencoderAsync.Finished += this.mencoder_Finished;
+    mencoderAsync.ProgressChanged += this.mencoder_Progress;
 }
 
 private void mencoder_Finished(object sender, EventArgs e)