freebuff: Attempt e2e test fix with waitForReady

Author: jahooma

freebuff/e2e/tests/code-edit.e2e.test.ts

@@ -52,11 +52,14 @@ describe('Freebuff: Code Edit', () => {
         initialFiles: { 'index.js': initialContent },
       })
 
+      // Wait for the CLI to be fully ready before sending input
+      await session.waitForReady()
+
       // Verify the file was created
       expect(session.readFile('index.js')).toBe(initialContent)
 
       // Send a prompt asking freebuff to add a console.log
-      await session.send("Add a console.log('hello world') to index.js")
+      await session.send('Add console.log("hello world") to index.js')
 
       // Wait for the file to be modified with the console.log
       const finalContent = await session.waitForFileContent(

freebuff/e2e/tests/knowledge-file.e2e.test.ts

@@ -49,6 +49,9 @@ describe('Freebuff: Knowledge Files', () => {
         },
       })
 
+      // Wait for the CLI to be fully ready before sending input
+      await session.waitForReady()
+
       await session.send('What is the project keyword? Reply with only the keyword.')
 
       const output = await session.waitForText(keyword, 120_000)

freebuff/e2e/tests/terminal-command.e2e.test.ts

@@ -41,10 +41,13 @@ describe('Freebuff: Terminal Command', () => {
       const binary = requireFreebuffBinary()
       session = await FreebuffSession.start(binary, { waitSeconds: 5 })
 
+      // Wait for the CLI to be fully ready before sending input
+      await session.waitForReady()
+
       // Ask freebuff to run a shell command whose output can only come from
       // actual terminal execution (not file-writing tools)
       await session.send(
-        'Use the terminal to run: date +%s > timestamp.txt && echo done',
+        'Execute a shell command in the terminal to write the current Unix timestamp in seconds to timestamp.txt',
       )
 
       // Wait for the file to be created by the terminal command

freebuff/e2e/utils/freebuff-session.ts

@@ -103,9 +103,33 @@ export class FreebuffSession {
     } catch {
       // ignore
     }
+    const terminalOutput = await this.capture()
     throw new Error(
       `Timed out after ${timeoutMs}ms waiting for "${pattern}" in ${relativePath}.\n` +
-        `Last content:\n${finalContent}`,
+        `Last content:\n${finalContent}\n` +
+        `Terminal output:\n${terminalOutput}`,
+    )
+  }
+
+  /**
+   * Wait for the CLI to be fully initialized and ready for input.
+   * Polls terminal output until enough non-empty lines are visible,
+   * indicating the TUI has rendered its initial layout.
+   */
+  async waitForReady(timeoutMs = 15_000, minLines = 5): Promise<void> {
+    const start = Date.now()
+    while (Date.now() - start < timeoutMs) {
+      const output = await this.capture()
+      const nonEmptyLines = output
+        .split('\n')
+        .filter((line) => line.trim().length > 0)
+      if (nonEmptyLines.length >= minLines) return
+      await new Promise((resolve) => setTimeout(resolve, 250))
+    }
+    const finalOutput = await this.capture()
+    throw new Error(
+      `Timed out after ${timeoutMs}ms waiting for CLI to be ready.\n` +
+        `Last output:\n${finalOutput}`,
     )
   }