Fixes for PLDM file transfer #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkj
force-pushed
the
pr/pldm-fixes
branch
2 times, most recently
from
280a651 to
480b485
Compare
Non-release builds run out of SRAM3. Build xspiloader in CI too Signed-off-by: Matt Johnston <[email protected]>
Signed-off-by: Matt Johnston <[email protected]>
This has better performance than using software implementation. Must be used in Blocking mode since Async is broken (in embassy, but the peripheral hardware looks awkward to use too). Signed-off-by: Matt Johnston <[email protected]>
Some changes have now been released, but still need git revision for a fix to embassy-stm32 when using log feature. Signed-off-by: Matt Johnston <[email protected]>
Signed-off-by: Matt Johnston <[email protected]>
May have minor performance improvement Signed-off-by: Matt Johnston <[email protected]>
This is located in sram2 that has spare space. Part size has a large impact on transfer performance. This updates pldm-file crate and other mctp-rs crates, with fixes for PLDM platform and PLDM file CRCs. Signed-off-by: Matt Johnston <[email protected]>
Provides additional admin commands. Signed-off-by: Matt Johnston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some CRC issues in crates used for PLDM files transfer.
nvme-mi-dev is updated with more command support.
Transfer performance has some improvement from using larger part buffers.