Low: tools: Fix memory leak in crm_resource.c:option_cb()

nrwahl2 · nrwahl2 · commit 6a4276430bbf · 2025-03-03T11:18:37.000-08:00
Found by Coverity

Signed-off-by: Reid Wahl &lt;nrwahl@protonmail.com&gt;
diff --git a/tools/crm_resource.c b/tools/crm_resource.c
@@ -806,6 +806,8 @@ option_cb(const gchar *option_name, const gchar *optarg, gpointer data,
     char *value = NULL;
 
     if (pcmk__scan_nvpair(optarg, &name, &value) != 2) {
+        free(name);
+        free(value);
         return FALSE;
     }
     if (options.cmdline_params == NULL) {

Original file line number	Diff line number	Diff line change
`@@ -806,6 +806,8 @@ option_cb(const gchar option_name, const gchar optarg, gpointer data,`
`806`	`806`	`char *value = NULL;`
`807`	`807`
`808`	`808`	`if (pcmk__scan_nvpair(optarg, &name, &value) != 2) {`
	`809`	`+ free(name);`
	`810`	`+ free(value);`
`809`	`811`	`return FALSE;`
`810`	`812`	`}`
`811`	`813`	`if (options.cmdline_params == NULL) {`