Add support for multi-file concatenation for NCCatalog#385
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 18 18
Lines 2005 2028 +23
=======================================
+ Hits 1994 2017 +23
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
What does mfds stand for? Multi-file data struct? |
Multi file dataset |
imreddyTeja
left a comment
imreddyTeja
left a comment
There was a problem hiding this comment.
Would this be a breaking change because NCCatalog is an exported struct?
| if isempty(maybe_short_name_pairs) | ||
| short_name = nothing | ||
| else | ||
| maybe_short_name_pair = first(short_names) |
There was a problem hiding this comment.
I know this is not a new addition, but I'm a bit confused on what this is doing
There was a problem hiding this comment.
I need to get a short name to figure out what the time dimension is. There is probably a better way of doing this now that I think about it.
There was a problem hiding this comment.
I used the short name since I needed to check if the start_date attribute is consistent between all the datasets. I think a better way of doing this is to scan all the variable names and check that all of them has a start date or don't has a start date.
I don't think this will be a breaking change? There are changes to the internals of the struct, but none of our code make use of the internals and they shouldn't anyway. |
ph-kev
force-pushed
the
kp/catalog
branch
2 times, most recently
from
09b02f5 to
c29fade
Compare
ph-kev
force-pushed
the
kp/catalog
branch
2 times, most recently
from
4497767 to
970e191
Compare
imreddyTeja
left a comment
imreddyTeja
left a comment
There was a problem hiding this comment.
One nit about some wording
2 participants
closes #322 - This PR adds support for multi-file concatenation for
NCCatalogby reusing the same functionality inread_var.