-
Notifications
You must be signed in to change notification settings - Fork 176
Expected to return JSON but returning string #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Problem:
The localStorage ("recover") is double stringified causing the recover circuit to always show untitled
Fixed:
The function signature mentioned returning JSON but string was sent.
Removed the unnessary conversion before return
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughgenerateSaveData in v0/src/simulator/src/data/save.js now returns the aggregated save data object directly instead of a JSON string. The serialization step (JSON conversion) was removed. No other logic or exported declarations were modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aryanndwi123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vnydv , thanks for catching that! Once we’ve stabilized the current version, we’ll sync the changes to v1.

Problem:
The
localStorage ("recover")is double stringified causing the recover circuit to always show untitledFixed:
The function signature mentioned returning JSON but string was sent. Removed the unnessary conversion before return
Further note:
Same issue in v1, @maintainers please change there also
Summary by CodeRabbit