Handle Not Found Proposal Gracfully (#86)

* first try

* .

* .

Author: liav-certora

src/quorum/apis/governance/aave_governance.py

@@ -24,6 +24,22 @@
 }
 
 
+class ProposalNotFoundException(Exception):
+    def __init__(
+        self, proposal_id: int, project_name: str, response: requests.Response
+    ):
+        super().__init__()
+        self.proposal_id = proposal_id
+        self.project_name = project_name
+        self.response = response
+
+    def __str__(self):
+        return (
+            f"Proposal id {self.proposal_id} for {self.project_name} could not be found "
+            f"at url {self.response.url} (error code {self.response.status_code})"
+        )
+
+
 class AaveGovernanceAPI:
     """
     A utility class to interact with the BGD governance cache and retrieve
@@ -45,7 +61,10 @@ def get_proposal_data(self, proposal_id: int) -> BGDProposalData:
         """
         proposal_data_link = f"{PROPOSALS_URL}/{proposal_id}.json"
         resp = self.session.get(proposal_data_link)
-        resp.raise_for_status()
+        try:
+            resp.raise_for_status()
+        except requests.HTTPError as e:
+            raise ProposalNotFoundException(proposal_id, "Aave", e.response) from e
 
         raw_json = resp.json()
         # Parse into our data model

src/quorum/auto_report/aave_tags.py

@@ -65,7 +65,6 @@ def get_aave_tags(proposal_id: int) -> dict[str, Any]:
     """
     api = AaveGovernanceAPI()
     bgd_data: BGDProposalData = api.get_proposal_data(proposal_id)
-
     # Safely unwrap fields (some might be None).
     ipfs_data: IPFSData = bgd_data.ipfs or IPFSData()
     proposal_data: ProposalData = bgd_data.proposal or ProposalData()

src/quorum/entry_points/implementations/create_report.py

@@ -5,6 +5,7 @@
 
 import quorum.auto_report.aave_tags as aave_tags
 import quorum.utils.pretty_printer as pp
+from quorum.apis.governance.aave_governance import ProposalNotFoundException
 
 
 def run_create_report(args: argparse.Namespace):
@@ -40,7 +41,11 @@ def run_create_report(args: argparse.Namespace):
     pp.pprint(
         f"Retrieving tag information for proposal {args.proposal_id}", pp.Colors.INFO
     )
-    tags = aave_tags.get_aave_tags(args.proposal_id)
+    try:
+        tags = aave_tags.get_aave_tags(args.proposal_id)
+    except ProposalNotFoundException as e:
+        pp.pprint(e, pp.Colors.FAILURE)
+        return
     pp.pprint("Tag information retrieved", pp.Colors.INFO)
 
     report = template.render(tags)