Skip to content

Commit 6f8ae64

Browse files
authored
Merge pull request #16 from pimcore/11.x-from-7114743095
Automated PR
2 parents 4145da6 + 09d7411 commit 6f8ae64

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

lib/Navigation/Builder.php

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,11 @@ class Builder
3232

3333
/**
3434
* @internal
35-
*
3635
*/
3736
protected ?string $htmlMenuIdPrefix = null;
3837

3938
/**
4039
* @internal
41-
*
4240
*/
4341
protected string $pageClass = DocumentPage::class;
4442

@@ -76,8 +74,8 @@ protected function configureOptions(OptionsResolver $options): void
7674

7775
$options->setAllowedTypes('root', [Document::class, 'null']);
7876
$options->setAllowedTypes('htmlMenuPrefix', ['string', 'null']);
79-
$options->setAllowedTypes('pageCallback', ['callable', 'null']);
80-
$options->setAllowedTypes('rootCallback', ['callable', 'null']);
77+
$options->setAllowedTypes('pageCallback', [\Closure::class, 'null']);
78+
$options->setAllowedTypes('rootCallback', [\Closure::class, 'null']);
8179
$options->setAllowedTypes('cache', ['string', 'bool']);
8280
$options->setAllowedTypes('cacheLifetime', ['int', 'null']);
8381
$options->setAllowedTypes('maxDepth', ['int', 'null']);
@@ -94,8 +92,8 @@ protected function resolveOptions(array $options): array
9492
* @param array{
9593
* root?: ?Document,
9694
* htmlMenuPrefix?: ?string,
97-
* pageCallback?: ?callable,
98-
* rootCallback?: ?callable,
95+
* pageCallback?: ?\Closure,
96+
* rootCallback?: ?\Closure,
9997
* cache?: string|bool,
10098
* cacheLifetime?: ?int,
10199
* maxDepth?: ?int,
@@ -184,8 +182,6 @@ public function getNavigation(array $params): Container
184182

185183
/**
186184
* @internal
187-
*
188-
*
189185
*/
190186
protected function markActiveTrail(Container $navigation, ?Document $activeDocument): void
191187
{
@@ -272,7 +268,6 @@ protected function findActivePages(Container $navigation, string $property, stri
272268
}
273269

274270
/**
275-
*
276271
* @throws \Exception
277272
*
278273
* @internal
@@ -316,15 +311,13 @@ public function setPageClass(string $pageClass): static
316311

317312
/**
318313
* Returns the name of the pageclass
319-
*
320314
*/
321315
public function getPageClass(): string
322316
{
323317
return $this->pageClass;
324318
}
325319

326320
/**
327-
*
328321
* @return Document[]
329322
*/
330323
protected function getChildren(Document $parentDocument): array
@@ -339,7 +332,6 @@ protected function getChildren(Document $parentDocument): array
339332
}
340333

341334
/**
342-
*
343335
* @return Page[]
344336
*
345337
* @throws \Exception

0 commit comments

Comments
 (0)