make connected keyword writable for pi-daemon#143
Open
mikelangmayr wants to merge 1 commit into
Open
Conversation
mikelangmayr
commented
Jun 8, 2026
mikelangmayr
commented
Contributor
- make connected keyword writable for pi-daemon
danechever
reviewed
Jun 8, 2026
| if not (self.ip_address and self.tcp_port): | ||
| raise RuntimeError("no hardware ip_address/tcp_port configured") | ||
| # Disconnect the whole daisy chain before reconnecting | ||
| self.controller.disconnect_all() |
Contributor
There was a problem hiding this comment.
It looks like a request to "connect" when the daemon is already connected will lead the daemon to disconnect then reconnect. You could instead consider having it just check if the connection is good and if it is, doing nothing; no need to toggle the connection.
Contributor
Author
There was a problem hiding this comment.
@danechever if it's connected it will just return, that's the _controller_repsonsive() check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.