Skip to content

Commit fbadc98

Browse files
committed
Fix broken UT.
1 parent e1e45c1 commit fbadc98

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

UnitTestProject1/Tests/CargoTests.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ public class CargoTests : WikiSiteTestsBase, IClassFixture<WikiSiteProvider>
1515
/// <inheritdoc />
1616
public CargoTests(ITestOutputHelper output, WikiSiteProvider wikiSiteProvider) : base(output, wikiSiteProvider)
1717
{
18+
// For Cargo queries.
19+
SiteNeedsLogin(Endpoints.LolEsportsWiki);
1820
}
1921

2022
[Fact]
@@ -31,7 +33,11 @@ public async Task BasicCargoQueryTest()
3133
ShallowTrace(result.Select(r => r.ToJsonString()));
3234
Assert.Equal(10, result.Count);
3335
Assert.All(result, r => Assert.Equal((string?)r["Page"], (string?)r["Name"]));
34-
Assert.All(result, r => Assert.True(r["RP"] == null || Convert.ToInt32((string?)r["RP"]) > 0));
36+
Assert.All(result, r => Assert.True((string?)r["RP"] switch
37+
{
38+
null or "" => true,
39+
var s => Convert.ToInt32(s) > 0,
40+
}));
3541
}
3642

3743
[Fact]

UnitTestProject1/Tests/PageTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,15 +151,15 @@ public async Task WpEnPageCategoriesTest()
151151

152152
var catParis = cats.FirstOrDefault(c => c.Title == "Category:Paris");
153153
var catCapitalsInEurope = cats.FirstOrDefault(c => c.Title == "Category:Capitals in Europe");
154-
var catGoodArticles = cats.FirstOrDefault(c => c.Title == "Category:Good articles");
154+
var catCoordinatesInWikidata = cats.FirstOrDefault(c => c.Title == "Category:Coordinates on Wikidata");
155155

156156
Assert.NotNull(catParis);
157157
Assert.NotNull(catCapitalsInEurope);
158-
Assert.NotNull(catGoodArticles);
158+
Assert.NotNull(catCoordinatesInWikidata);
159159

160160
Assert.False(catParis.IsHidden);
161161
Assert.False(catCapitalsInEurope.IsHidden);
162-
Assert.True(catGoodArticles.IsHidden);
162+
Assert.True(catCoordinatesInWikidata.IsHidden);
163163
}
164164

165165
[Fact]

0 commit comments

Comments
 (0)