Merge pull request #18 from FaFre/fix-issue-17

fixed deep clones of various classes

Author: CXuesong

.gitignore

@@ -243,3 +243,6 @@ ModelManifest.xml
 
 _private/
 **/Properties/launchSettings.json
+
+#VSCode
+.vscode/

MwParserFromScratch/Nodes/Inline.cs

@@ -96,7 +96,7 @@ protected override Node CloneCore()
 
         /// <inheritdoc />
         public override string ToString() => Text == null ? $"[[{Target}]]" : $"[[{Target}|{Text}]]";
-        
+
         /// <param name="builder"></param>
         /// <param name="formatter"></param>
         /// <inheritdoc />
@@ -153,7 +153,7 @@ public WikiImageLink(Run target)
             Target = target;
             Arguments = new WikiImageLinkArgumentCollection(this);
         }
-        
+
         /// <summary>
         /// Title of the image.
         /// </summary>
@@ -207,7 +207,7 @@ internal override void ToPlainTextCore(StringBuilder builder, NodePlainTextForma
             if (alt != null) formatter(alt, builder);
             var caption = Arguments.Caption;
             // delimit alt text and caption with a space.
-            if (alt != null && caption != null) 
+            if (alt != null && caption != null)
                 builder.Append(' ');
             if (caption != null) formatter(caption, builder);
         }
@@ -324,7 +324,12 @@ public override IEnumerable<Node> EnumChildren()
 
         protected override Node CloneCore()
         {
-            return new ExternalLink { Target = Target, Text = Text };
+            return new ExternalLink
+            {
+                Target = Target,
+                Text = Text,
+                Brackets = Brackets
+            };
         }
 
         public override string ToString()
@@ -342,7 +347,7 @@ internal override void ToPlainTextCore(StringBuilder builder, NodePlainTextForma
         {
             if (!Brackets)
             {
-                formatter( Target, builder);
+                formatter(Target, builder);
             }
             else
             {
@@ -459,7 +464,7 @@ public override IEnumerable<Node> EnumChildren()
 
         protected override Node CloneCore()
         {
-            var n = new Template { Name = Name };
+            var n = new Template { Name = Name, IsMagicWord = IsMagicWord };
             n.Arguments.Add(Arguments);
             return n;
         }
@@ -714,7 +719,7 @@ public string ClosingTagTrailingWhitespace
         public TagAttributeCollection Attributes { get; }
 
         protected abstract void BuildContentString(StringBuilder builder);
-        
+
         /// <summary>
         /// Enumerates the children of this node.
         /// </summary>
@@ -1009,7 +1014,15 @@ public override IEnumerable<Node> EnumChildren()
 
         protected override Node CloneCore()
         {
-            return new TagAttribute { Name = Name, Value = Value };
+            return new TagAttribute
+            {
+                Name = Name,
+                Value = Value,
+                Quote = Quote,
+                LeadingWhitespace = LeadingWhitespace,
+                WhitespaceAfterEqualSign = WhitespaceAfterEqualSign,
+                WhitespaceBeforeEqualSign = WhitespaceBeforeEqualSign
+            };
         }
 
         public override string ToString()

MwParserFromScratch/Nodes/Wikitext.cs

@@ -40,8 +40,7 @@ public override IEnumerable<Node> EnumChildren()
 
         protected override Node CloneCore()
         {
-            var n = new Wikitext();
-            n.Lines.Add(Lines);
+            var n = new Wikitext(Lines);
             return n;
         }
 
@@ -223,7 +222,7 @@ public override string ToString()
             return string.Join(null, Inlines);
         }
     }
-    
+
     public class ListItem : InlineContainerLineNode
     {
         public ListItem()
@@ -319,7 +318,7 @@ public override IEnumerable<Node> EnumChildren()
 
         protected override Node CloneCore()
         {
-            var n = new Heading(Inlines) { Level = Level };
+            var n = new Heading(Inlines) { Level = Level, Suffix = Suffix };
             return n;
         }