Skip to content

Potential bug of hyperboloid frechet mean #4

@ljxw88

Description

@ljxw88

Applying frechet mean on the Lorentz model with K not equal to -1 cannot get the correct answer.

I found the bug in frechetmean/forward/hyperboloid_forward.py. Where the original code calculate variable mu with
mu = u / torch.sqrt(K * Lorentz._ldot(u, u, keepdim=True))

Changing it to
mu = - K * u / torch.sqrt(K * Lorentz._ldot(u, u, keepdim=True))
solves the problem.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions