Skip to content

Commit 33b8a61

Browse files
committed
Address some firestore typing issues. Fixes #120
1 parent 2d1a5f9 commit 33b8a61

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed

firestore/useCollection.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,44 +13,44 @@ import {
1313
import { useIsEqualRef, useLoadingValue } from '../util';
1414

1515
export const useCollection = <T = firebase.firestore.DocumentData>(
16-
query?: firebase.firestore.Query<T> | null,
16+
query?: firebase.firestore.Query | null,
1717
options?: Options
1818
): CollectionHook<T> => {
19-
return useCollectionInternal(true, query, options);
19+
return useCollectionInternal<T>(true, query, options);
2020
};
2121

2222
export const useCollectionOnce = <T = firebase.firestore.DocumentData>(
2323
query?: firebase.firestore.Query<T> | null,
2424
options?: OnceOptions
2525
): CollectionHook<T> => {
26-
return useCollectionInternal(false, query, options);
26+
return useCollectionInternal<T>(false, query, options);
2727
};
2828

2929
export const useCollectionData = <
3030
T = firebase.firestore.DocumentData,
3131
IDField extends string = '',
3232
RefField extends string = ''
3333
>(
34-
query?: firebase.firestore.Query<T> | null,
34+
query?: firebase.firestore.Query | null,
3535
options?: DataOptions<T>
3636
): CollectionDataHook<T, IDField, RefField> => {
37-
return useCollectionDataInternal(true, query, options);
37+
return useCollectionDataInternal<T, IDField, RefField>(true, query, options);
3838
};
3939

4040
export const useCollectionDataOnce = <
4141
T = firebase.firestore.DocumentData,
4242
IDField extends string = '',
4343
RefField extends string = ''
4444
>(
45-
query?: firebase.firestore.Query<T> | null,
45+
query?: firebase.firestore.Query | null,
4646
options?: OnceDataOptions<T>
4747
): CollectionDataHook<T, IDField, RefField> => {
48-
return useCollectionDataInternal(false, query, options);
48+
return useCollectionDataInternal<T, IDField, RefField>(false, query, options);
4949
};
5050

5151
const useCollectionInternal = <T = firebase.firestore.DocumentData>(
5252
listen: boolean,
53-
query?: firebase.firestore.Query<T> | null,
53+
query?: firebase.firestore.Query | null,
5454
options?: Options & OnceOptions
5555
) => {
5656
const { error, loading, reset, setError, setValue, value } = useLoadingValue<
@@ -99,7 +99,7 @@ const useCollectionDataInternal = <
9999
RefField extends string = ''
100100
>(
101101
listen: boolean,
102-
query?: firebase.firestore.Query<T> | null,
102+
query?: firebase.firestore.Query | null,
103103
options?: DataOptions<T> & OnceDataOptions<T>
104104
): CollectionDataHook<T, IDField, RefField> => {
105105
const idField = options ? options.idField : undefined;

firestore/useDocument.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import firebase from 'firebase/app';
2-
import { useEffect, useMemo } from 'react';
2+
import { Ref, useEffect, useMemo } from 'react';
33
import { snapshotToData } from './helpers';
44
import {
55
Data,
@@ -13,44 +13,44 @@ import {
1313
import { useIsEqualRef, useLoadingValue } from '../util';
1414

1515
export const useDocument = <T = firebase.firestore.DocumentData>(
16-
docRef?: firebase.firestore.DocumentReference<T> | null,
16+
docRef?: firebase.firestore.DocumentReference | null,
1717
options?: Options
1818
): DocumentHook<T> => {
19-
return useDocumentInternal(true, docRef, options);
19+
return useDocumentInternal<T>(true, docRef, options);
2020
};
2121

2222
export const useDocumentOnce = <T = firebase.firestore.DocumentData>(
23-
docRef?: firebase.firestore.DocumentReference<T> | null,
23+
docRef?: firebase.firestore.DocumentReference | null,
2424
options?: OnceOptions
2525
): DocumentHook<T> => {
26-
return useDocumentInternal(false, docRef, options);
26+
return useDocumentInternal<T>(false, docRef, options);
2727
};
2828

2929
export const useDocumentData = <
3030
T = firebase.firestore.DocumentData,
3131
IDField extends string = '',
3232
RefField extends string = ''
3333
>(
34-
docRef?: firebase.firestore.DocumentReference<T> | null,
34+
docRef?: firebase.firestore.DocumentReference | null,
3535
options?: DataOptions<T>
3636
): DocumentDataHook<T, IDField, RefField> => {
37-
return useDocumentDataInternal(true, docRef, options);
37+
return useDocumentDataInternal<T, IDField, RefField>(true, docRef, options);
3838
};
3939

4040
export const useDocumentDataOnce = <
4141
T = firebase.firestore.DocumentData,
4242
IDField extends string = '',
4343
RefField extends string = ''
4444
>(
45-
docRef?: firebase.firestore.DocumentReference<T> | null,
45+
docRef?: firebase.firestore.DocumentReference | null,
4646
options?: OnceDataOptions<T>
4747
): DocumentDataHook<T, IDField, RefField> => {
48-
return useDocumentDataInternal(false, docRef, options);
48+
return useDocumentDataInternal<T, IDField, RefField>(false, docRef, options);
4949
};
5050

5151
const useDocumentInternal = <T = firebase.firestore.DocumentData>(
5252
listen: boolean,
53-
docRef?: firebase.firestore.DocumentReference<T> | null,
53+
docRef?: firebase.firestore.DocumentReference | null,
5454
options?: Options & OnceOptions
5555
): DocumentHook<T> => {
5656
const { error, loading, reset, setError, setValue, value } = useLoadingValue<
@@ -99,7 +99,7 @@ const useDocumentDataInternal = <
9999
RefField extends string = ''
100100
>(
101101
listen: boolean,
102-
docRef?: firebase.firestore.DocumentReference<T> | null,
102+
docRef?: firebase.firestore.DocumentReference | null,
103103
options?: DataOptions<T>
104104
): DocumentDataHook<T, IDField, RefField> => {
105105
const idField = options ? options.idField : undefined;

0 commit comments

Comments
 (0)