fix nonexistent id cache causing legacy shares to break synchronization (merge commit)

Merge branch 'bugfix/hotfix-ignore-missing-id-for-legacy-shares' into 'main'
* fix nonexistent id cache causing legacy shares to break synchronization

See merge request https://gitlab.ci.csc.fi/sds-dev/sd-connect/swift-browser-ui/-/merge_requests/366

Approved-by: Teemu Kataja <[email protected]>
Co-authored-by: Sampsa Penna <[email protected]>
Merged by Sampsa Penna <[email protected]>

Author: Sampsa Penna

swift_browser_ui_frontend/src/common/conv.js

@@ -112,31 +112,38 @@ export async function syncContainerACLs(store) {
       if (aclmeta[container][share].read) {
         // Check if the shared access only concerns view rights
         let tmpid = await client.projectCheckIDs(share);
+        let whitelisted = false;
+
+        if (tmpid !== undefined) {
+          let whitelistUrl = new URL(store.state.uploadEndpoint.concat(
+            `/check/${store.state.active.name}/${container}/${tmpid.name}`,
+          ));
+          let signatureUrl = new URL("/sign/3600", document.location.origin);
+          signatureUrl.searchParams.append(
+            "path",
+            `/check/${store.state.active.name}/${container}/${tmpid.name}`,
+          );
+          let signed = await GET(signatureUrl);
+          signed = await signed.json();
+          whitelistUrl.searchParams.append("valid", signed.valid);
+          whitelistUrl.searchParams.append("signature", signed.signature);
+
+          let whitelistedResp = await fetch(
+            whitelistUrl,
+            {
+              method: "GET",
+            },
+          );
+
+          if (whitelistedResp.status == 200) {
+            whitelisted = true;
+          }
+        }
 
-        let whitelistUrl = new URL(store.state.uploadEndpoint.concat(
-          `/check/${store.state.active.name}/${container}/${tmpid.name}`,
-        ));
-        let signatureUrl = new URL("/sign/3600", document.location.origin);
-        signatureUrl.searchParams.append(
-          "path",
-          `/check/${store.state.active.name}/${container}/${tmpid.name}`,
-        );
-        let signed = await GET(signatureUrl);
-        signed = await signed.json();
-        whitelistUrl.searchParams.append("valid", signed.valid);
-        whitelistUrl.searchParams.append("signature", signed.signature);
-
-        let whitelisted = await fetch(
-          whitelistUrl,
-          {
-            method: "GET",
-          },
-        );
-
-        if (whitelisted.status == 204) {
-          accesslist.push("v");
-        } else {
+        if (whitelisted) {
           accesslist.push("r");
+        } else {
+          accesslist.push("v");
         }
       }
       if (aclmeta[container][share].write) {

swift_browser_ui_frontend/src/common/swift_x_account_sharing_bind.js

@@ -323,7 +323,10 @@ class SwiftXAccountSharing {
       },
     ).then(
       (resp) => {
-        return resp.json();
+        if (resp.status == 200) {
+          return resp.json();
+        }
+        else return undefined;
       },
     );