linting

Author: laurenkrugen-navapbc

ssas/service/tokendenylist_test.go

@@ -3,6 +3,7 @@ package service
 import (
 	"context"
 	"crypto/rand"
+	"database/sql"
 	"math/big"
 	"strconv"
 	"testing"
@@ -45,9 +46,12 @@ func (s *TokenCacheTestSuite) SetupTest() {
 }
 
 func (s *TokenCacheTestSuite) TearDownTest() {
+	var err error
+	var db *sql.DB
 	s.d.c.Flush()
-	err := s.db.Exec("DELETE FROM denylist_entries;").Error
-	db, err := s.db.DB()
+	err = s.db.Exec("DELETE FROM denylist_entries;").Error
+	require.NoError(s.T(), err)
+	db, err = s.db.DB()
 	require.NoError(s.T(), err)
 	db.Close()
 	assert.Nil(s.T(), err)

ssas/systems.go

@@ -512,8 +512,9 @@ func (r *SystemsRepository) registerSystem(ctx context.Context, input SystemInpu
 	}
 
 	var group Group
-	if err := tx.WithContext(ctx).First(&group, "group_id = ?", input.GroupID).Error; err != nil && errors.Is(err, gorm.ErrRecordNotFound) {
-		err = fmt.Errorf("no Group record found for groupID %s", input.GroupID)
+	err = tx.WithContext(ctx).First(&group, "group_id = ?", input.GroupID).Error
+	if err != nil && errors.Is(err, gorm.ErrRecordNotFound) {
+		return creds, fmt.Errorf("no Group record found for groupID %s", input.GroupID)
 	}
 
 	system := System{