Triangulation on hyperbolic surface 2: Delaunay triangulations and epsilon-nets #9158
Conversation
Still need to fix what causes segfaults in debug mode
Rationale: made segfaults and didn't want to spend time debuggin. Maybe later.
Rationale: not needed
Rationale: former algo would not work for domains with 2 or more vertices
… in the parameters
insert -> split insert Delaunay_insert -> insert
…ation_class-camille-lanuel' of github.com:camille-lanuel/cgal into Triangulation_on_hyperbolic_surface_2-Delaunay_triangulation_class-camille-lanuel
|
/build:v1 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9158/v1/Manual/index.html |
MaelRL
added
Not yet approved
..._2/doc/Triangulation_on_hyperbolic_surface_2/CGAL/Triangulation_on_hyperbolic_surface_2_IO.h
Outdated
Show resolved
Hide resolved
|
I know that it is not a mistake introduced by this PR, but can you add the |
|
And a typo "reprensenting" here Also there should not be text in red in the User Manual |
|
"\f$ \varepsilon \f$-net" as that in the html here |
| \return a vector with the vertices of a Dirichlet domain whose base point is translated to the origin of the Poincaré disk. | ||
| `domain` must be a fundamental domain whose vertices represent a same point on the corresponding hyperbolic surface. |
There was a problem hiding this comment.
| `domain` must be a fundamental domain whose vertices represent a same point on the corresponding hyperbolic surface. | |
| @param domain must be a fundamental domain whose vertices represent a same point on the corresponding hyperbolic surface. |
I think I got it. Red means what you added in this PR |
|
You must add Kernel_23 in the dependencies file |
Kernel_23 is already in /package_info/dependencies. Do you mean to add it in /doc/dependencies ? |
Yes, because you use |
3 participants
Summary of Changes
This feature implements Delaunay triangulations on hyperbolic surfaces. Functionalities include point location, point insertion, and the computation of an ε-net of the hyperbolic surface, which is a set of well-distributed points on the surface controlled by the parameter ε.
Release Management