Point_set: move IO code to Stream_support #9109
Open
+2,154
−1,700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Breaks at least classification in CGAL-6.2-Ic-26 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
sloriot
added a commit
that referenced
this pull request
Nov 20, 2025
## Summary of Changes For file formats that expect floating point coordinates we convert on the fly so that `CGAL::io::write_polygon_soup()` also works for polygon soups with ` FT` which are non-float/double, e.g. `Exact_predicates_exact_constructions_kernel`. Additionally, we document the named parameter `point_map` as it was missing. ## Release Management * Affected package(s): Stream_support * Issue(s) solved (if any): fix #9071 * License and copyright ownership: unchanged * upon integration update and test #9109
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
There was an error while building the doc: |
Member
Author
|
/force-build:v0 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9109/v0/Manual/index.html |
lrineau
reviewed
Nov 20, 2025
Member
lrineau
left a comment
lrineau
left a comment
There was a problem hiding this comment.
I think there should be backward-compatibility headers, to replace the removed headers.
Member
Author
Which one is missing? |
Member
Sorry. I read the diff to fast. They are present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Make
Point_set_3independent fromPoint_set_processing. No API changes and no changes in#includedirectories.Release Management