Skip to content

Ball merge reconstruction #8048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
amaldevp wants to merge 62 commits into
base: main
Choose a base branch
from
Open

Ball merge reconstruction #8048

amaldevp wants to merge 62 commits into from

Conversation

@amaldevp
Copy link

@amaldevp amaldevp commented Feb 26, 2024 •
edited by sloriot
Loading

Summary of Changes

Add a new package in CGAL implementing the reconstruction algorithm described in Amal Dev Parakkat, Stefan Ohrhallinger, Elmar Eisemann, and Pooran Memari. Ballmerge: High-quality fast surface reconstruction via voronoi balls. In Computer Graphics Forum, 2024.

Release Management

TODO

  • update changes
  • check branch size (@sloriot)
  • add example output of increasing complexity and real world example with parameters
  • show cases that are failing

@sloriot sloriot force-pushed the Ball_merge_reconstruction branch from 4167c31 to bb04afc Compare February 27, 2024 06:15
@sloriot
Copy link
Member

sloriot commented Feb 27, 2024

/build:v1

@github-actions
Copy link

github-actions bot commented Feb 27, 2024

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8048/v1/Manual/index.html

@github-actions
Copy link

github-actions bot commented Feb 12, 2025

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8048/v2/Manual/index.html

@MaelRL MaelRL modified the milestones: 6.1-beta, 6.2-beta Mar 17, 2025
afabri
afabri requested changes Jul 16, 2025
View reviewed changes
@sloriot sloriot changed the base branch from master to main September 18, 2025 05:55
@sloriot
Copy link
Member

sloriot commented Sep 23, 2025

/build:v3

@sloriot
Copy link
Member

sloriot commented Sep 23, 2025

The documentation is built here: https://cgal.github.io/8048/v3/Ball_merge_surface_reconstruction/index.html

@github-actions
Copy link

github-actions bot commented Sep 23, 2025

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8048/v3/Manual/index.html

afabri
afabri reviewed Oct 2, 2025
View reviewed changes
Ball_merge_surface_reconstruction/include/CGAL/Ball_merge_surface_reconstruction.h
Delaunay m_dt3;

double distance(const Point& p1, const Point& p2) const
{ return std::sqrt(typename Traits::Compute_squared_distance_3()(p1,p2)); }
Copy link
Member

@afabri afabri Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sloriot does that not need a to_double() ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sloriot sloriot sloriot left review comments

@afabri afabri afabri requested changes

Assignees

No one assigned

Labels

Feature Not yet approved The feature or pull-request has not yet been approved. Previously tested TODO (web)

Projects

None yet

Milestone

6.2-beta

Development

Successfully merging this pull request may close these issues.

4 participants

@amaldevp @sloriot @afabri @MaelRL