Skip to content

Commit 7840e38

Browse files
committed
fix(ndp-RX): remove double sync on queue start
The packets received by the driver between these two synces were ignored in libnfb and even not freed. This could have caused performance issues (buffer was effectively smaller) or even blockage of packet receive.
1 parent 1d0ebcb commit 7840e38

File tree

1 file changed

+0
-3
lines changed
  • libnfb/include/netcope

1 file changed

+0
-3
lines changed

libnfb/include/netcope/ndp.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -372,9 +372,6 @@ static int nc_ndp_queue_start(void *priv)
372372
return ret;
373373

374374
if (q->channel.type == NDP_CHANNEL_TYPE_RX && q->protocol == 2 && (q->flags & NDP_CHANNEL_FLAG_EXCLUSIVE) == 0) {
375-
if ((ret = _ndp_queue_sync(q, &q->sync)))
376-
return ret;
377-
378375
q->u.v2.rhp = q->sync.hwptr;
379376
}
380377

0 commit comments

Comments
 (0)