Refactor PIINVOICE so env vars are fetched at start of billing pipeline.

Author: KelvinLinBU

process_report/invoices/pi_specific_invoice.py

@@ -1,5 +1,4 @@
 import os
-import sys
 from dataclasses import dataclass
 import subprocess
 import tempfile
@@ -27,6 +26,8 @@ class PIInvoice(invoice.Invoice):
     - NewPICreditProcessor
     """
 
+    chrome_binary_location: str
+
     TOTAL_COLUMN_LIST = [
         invoice.COST_FIELD,
         invoice.CREDIT_FIELD,
@@ -120,20 +121,12 @@ def _create_html_invoice(temp_fd):
             temp_fd.flush()
 
         def _create_pdf_invoice(temp_fd_name):
-            chrome_binary_location = os.environ.get(
-                "CHROME_BIN_PATH", "/usr/bin/chromium"
-            )
-            if not os.path.exists(chrome_binary_location):
-                sys.exit(
-                    f"Chrome binary does not exist at {chrome_binary_location}. Make sure the env var CHROME_BIN_PATH is set correctly and that Google Chrome is installed"
-                )
-
             invoice_pdf_path = (
                 f"{self.name}/{pi_instituition}_{pi}_{self.invoice_month}.pdf"
             )
             subprocess.run(
                 [
-                    chrome_binary_location,
+                    self.chrome_binary_location,
                     "--headless",
                     "--no-sandbox",
                     f"--print-to-pdf={invoice_pdf_path}",

process_report/process_report.py

@@ -109,6 +109,13 @@ def validate_required_env_vars():
 def main():
     """Remove non-billable PIs and projects"""
 
+    chrome_binary_location = os.environ.get("CHROME_BIN_PATH", "/usr/bin/chromium")
+
+    if not os.path.exists(chrome_binary_location):
+        sys.exit(
+            f"Chrome binary does not exist at {chrome_binary_location}. Make sure the env var CHROME_BIN_PATH is set correctly and that Google Chrome is installed"
+        )
+
     parser = argparse.ArgumentParser()
 
     parser.add_argument(
@@ -369,7 +376,10 @@ def main():
     )
 
     pi_inv = pi_specific_invoice.PIInvoice(
-        name=args.output_folder, invoice_month=invoice_month, data=processed_data
+        name=args.output_folder,
+        invoice_month=invoice_month,
+        data=processed_data,
+        chrome_binary_location=chrome_binary_location,
     )
 
     moca_prepaid_inv = MOCA_prepaid_invoice.MOCAPrepaidInvoice(

process_report/tests/util.py

@@ -55,17 +55,11 @@ def new_billable_invoice(
 
 
 def new_pi_specific_invoice(
-    name="",
-    invoice_month="0000-00",
-    data=None,
+    name="", invoice_month="0000-00", data=None, chrome_binary_path="/usr/bin/chromium"
 ):
     if data is None:
         data = pandas.DataFrame()
-    return pi_specific_invoice.PIInvoice(
-        name,
-        invoice_month,
-        data,
-    )
+    return pi_specific_invoice.PIInvoice(name, invoice_month, data, chrome_binary_path)
 
 
 def new_nerc_total_invoice(