Skip to content

Commit 22a915c

Browse files
authored
Merge pull request #121 from ByteInternet/proper_deployer_dependency
2 parents 67fe730 + 5e843bf commit 22a915c

File tree

4 files changed

+60
-29
lines changed

4 files changed

+60
-29
lines changed

.github/workflows/test.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ jobs:
1212
steps:
1313
- name: Checkout hypernode-deploy
1414
uses: actions/checkout@v3
15-
with:
16-
ref: ${{ github.event.pull_request.head.ref }}
1715
- name: Run general testsuite
1816
if: ${{ matrix.testsuite == 'general' }}
1917
run: MAGENTO_REPO=./magento2 ./runtests.sh general

README.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,23 @@ If you are looking to see how the internals of the deployment tool work or even
88

99
This project builds the `hypernode/deploy` container image, which can be found on [quay.io/hypernode/deploy](https://quay.io/hypernode/deploy).
1010

11+
## Updating deployer dependency
12+
13+
Deployer is an integral part of Hypernode Deploy.
14+
The official packagist distribution (and the git tags) are just phar distributions with all the engine code stripped away.
15+
To properly install Deployer as a dependency, we install a very simple fork, which has git tags based on the engine code.
16+
17+
Whenever a new Deployer version is released, here's the process:
18+
- Sync the fork [ByteInternet/deployer](https://github.com/ByteInternet/deployer)
19+
- Locate the commit for the release in the master branch.
20+
- Usually this comes down to finding the commit that was pushed most recent to the release tag.
21+
- Clone/update the fork locally.
22+
- Run `git checkout <commit_sha>`
23+
- Run `git tag v<version>`
24+
- Run `git push --tags`
25+
26+
Finally, to utilize the new fork in Hypernode Deploy, you can simply change the deployer/deployer dependency in the `composer.json` file.
27+
1128
## Building and running a local image
1229

1330
If you don't want to use a pre-built image from https://quay.io/hypernode/deploy or if you are doing development on this project and you want to test out your changes, you can built an image locally and use that.

composer.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"ext-pcntl": "*",
1313
"ext-zlib": "*",
1414
"composer-runtime-api": "^2",
15-
"deployer/deployer": "dev-master#a3bab59 as v7.4.0",
15+
"deployer/deployer": "v7.4.0",
1616
"doctrine/annotations": "^1.6",
1717
"guzzlehttp/guzzle": "^7.5",
1818
"hypernode/api-client": "^0.4",
@@ -50,5 +50,11 @@
5050
"phpro/grumphp-shim": true,
5151
"php-http/discovery": true
5252
}
53+
},
54+
"repositories": {
55+
"deployer-fork": {
56+
"type": "vcs",
57+
"url": "https://github.com/ByteInternet/deployer"
58+
}
5359
}
5460
}

composer.lock

Lines changed: 36 additions & 26 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)